Keep snapped stats in MetricSnapshotImpl.#18144
Merged
ggreenway merged 1 commit intoenvoyproxy:mainfrom Sep 20, 2021
Merged
Conversation
Signed-off-by: Pradeep Rao <pcrao@google.com>
Contributor
Author
|
/assign jmarantz |
jmarantz
approved these changes
Sep 16, 2021
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
/assign-from @envoyproxy/senior-maintainers
|
@envoyproxy/senior-maintainers assignee is @ggreenway |
ggreenway
approved these changes
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pradeep Rao pcrao@google.com
Defensively keep RefCountPtrs to stats around during the flush, guarding against stat deletions on the worker thread. Stats allocated with ThreadLocalStore are always deleted on the main thread after being cleared from the TLS caches, so this is not a problem in practice, but it does make sense to hold onto a shared-ptr in the sink.
Note that this is a transient state -- in a future PR the intermediate vectors can be dropped and lambda functions can be used to process all the sinked stats.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]