Skip to content

docs: Add remote_refuse and remote_reset in response code details #18132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmarantz merged 1 commit into from
Sep 15, 2021
Merged

docs: Add remote_refuse and remote_reset in response code details #18132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/root/configuration/http/http_conn_man/response_code_details.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ All http2 details are rooted at *http2.*
http2.unexpected_underscore, Envoy was configured to drop requests with header keys beginning with underscores.
http2.unknown.nghttp2.error, An unknown error was encountered by nghttp2
http2.violation.of.messaging.rule, The stream was in violation of a HTTP/2 messaging rule.
http2.remote_refuse, The peer refused the stream.
http2.remote_reset, The peer reset the stream.

Http3 details
~~~~~~~~~~~~~
Expand All @@ -116,4 +118,6 @@ All http3 details are rooted at *http3.*
http3.unexpected_underscore, Envoy was configured to drop or reject requests with header keys beginning with underscores.
http3.too_many_headers, Either incoming request or response headers contained too many headers.
http3.too_many_trailers, Either incoming request or response trailers contained too many entries.
http3.remote_refuse, The peer refused the stream.
http3.remote_reset, The peer reset the stream.

2 changes: 1 addition & 1 deletion source/common/http/http1/codec_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace Http1 {
namespace {

// Changes or additions to details should be reflected in
// docs/root/configuration/http/http_conn_man/response_code_details_details.rst
// docs/root/configuration/http/http_conn_man/response_code_details.rst
struct Http1ResponseCodeDetailValues {
const absl::string_view TooManyHeaders = "http1.too_many_headers";
const absl::string_view HeadersTooLarge = "http1.headers_too_large";
Expand Down
2 changes: 1 addition & 1 deletion source/common/http/http2/codec_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace Http {
namespace Http2 {

// Changes or additions to details should be reflected in
// docs/root/configuration/http/http_conn_man/response_code_details_details.rst
// docs/root/configuration/http/http_conn_man/response_code_details.rst
class Http2ResponseCodeDetailValues {
public:
// Invalid HTTP header field was received and stream is going to be
Expand Down