Make contrib filter visibility configurable#18131
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Sep 15, 2021
Merged
Make contrib filter visibility configurable#18131mattklein123 merged 2 commits intoenvoyproxy:mainfrom
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
Conversation
added 2 commits
September 15, 2021 00:59
Signed-off-by: Samra Belachew <sbelachew@lyft.com>
Signed-off-by: Samra Belachew <sbelachew@lyft.com>
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Sep 20, 2021
- updated bazel/repositories.bzl - .bazelrc already in sync - added `CONTRIB_EXTENSION_PACKAGE_VISIBILITY = ["//:contrib_library"]` to https://github.com/envoyproxy/nighthawk/blob/main/extensions_build_config.bzl to fix the failure from running `ci/do_ci.sh build` which is caused by envoyproxy/envoy#18131 - changed `api_.randomGenerator()` to `context_.api().randomGenerator()` in `ClusterManagerFactory` which is caused by envoyproxy/envoy#18122 Signed-off-by: qqustc@gmail.com <qqin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Creating a variable
CONTRIB_EXTENSION_PACKAGE_VISIBILITYto allow users to override default package visibility for contrib filters similar to existing filters.Additional Description:
Risk Level: Low
Testing: <TBD, could use some guidance on writing tests for a feature like this. I have little experience with bazel>
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features:
Fixes #Issue: #18106