factories: renaming to mainThreadDispatcher#18122
Merged
jmarantz merged 3 commits intoenvoyproxy:mainfrom Sep 17, 2021
Merged
Conversation
alyssawilk
requested review from
asraa,
ggreenway,
htuch,
junr03,
lizan,
mathetake,
mattklein123,
snowp and
zuercher
as code owners
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
more_factory
branch
from
826a308 to
68b2c3b
Compare
jmarantz
reviewed
Sep 15, 2021
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
oh this turned out to be much larger than I was expecting. I hope you had good tools to help you do all these changes.
it's going to take me a bit to get through this, as I have some perf deadlines coming up.
Contributor
Author
|
Yeah it's a doozy. I'm glad you were Ok with me splitting it out :-P |
jmarantz
approved these changes
Sep 17, 2021
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Sep 20, 2021
- updated bazel/repositories.bzl - .bazelrc already in sync - added `CONTRIB_EXTENSION_PACKAGE_VISIBILITY = ["//:contrib_library"]` to https://github.com/envoyproxy/nighthawk/blob/main/extensions_build_config.bzl to fix the failure from running `ci/do_ci.sh build` which is caused by envoyproxy/envoy#18131 - changed `api_.randomGenerator()` to `context_.api().randomGenerator()` in `ClusterManagerFactory` which is caused by envoyproxy/envoy#18122 Signed-off-by: qqustc@gmail.com <qqin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also using the new factory API in one more place which I can back out if you prefer.
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a