Skip to content

bazel: Switch py_script -> rules_python.entry_point#18046

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:bazel-entry-point
Sep 14, 2021
Merged

bazel: Switch py_script -> rules_python.entry_point#18046
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:bazel-entry-point

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Sep 9, 2021

Commit Message: bazel: Switch py_script -> rules_python.entry_point
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18046 was opened by phlax.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 9, 2021
@phlax phlax marked this pull request as draft September 9, 2021 15:42
@phlax phlax force-pushed the bazel-entry-point branch from a7f98e6 to 6603e71 Compare September 9, 2021 15:50
@phlax phlax changed the title [WIP] bazel: Switch py_script -> rules_python.entry_point [WIP] bazel: Switch py_script -> rules_python.entry_point Sep 9, 2021
@phlax phlax force-pushed the bazel-entry-point branch 2 times, most recently from b59a5b4 to 41f5ed2 Compare September 10, 2021 17:22
@phlax phlax changed the title [WIP] bazel: Switch py_script -> rules_python.entry_point bazel: Switch py_script -> rules_python.entry_point Sep 10, 2021
@phlax phlax marked this pull request as ready for review September 10, 2021 17:24
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Sep 13, 2021

cc @envoyproxy/dependency-shepherds for deps stamp

@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only
Copy link
Copy Markdown

no relevant owners for "deps"

🐱

Caused by: a #18046 (comment) was created by @moderation.

see: more, trace.

@phlax phlax merged commit 84f8666 into envoyproxy:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants