Skip to content

tooling: updating notifier to ping first pass reviewers #17938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 3 commits into from
Sep 1, 2021
Merged

tooling: updating notifier to ping first pass reviewers #17938

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
402a04d
tooling: updating notifier to ping first pass reviewers
alyssawilk Aug 31, 2021
d422e77
+adi
alyssawilk Aug 31, 2021
80c3a94
format
alyssawilk Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions .github/actions/pr_notifier/pr_notifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,20 @@
'rojkov': 'UH5EXLYQK',
}

# First pass reviewers who are not maintainers should get
# notifications but not result in a PR not getting assigned a
# maintainer owner.
FIRST_PASS = {
'adisuissa': 'UT17EMMTP',
'dmitri-d': 'UB1883Q5S',
'tonya11en': 'U989BG2CW',
'esmet': 'U01BCGBUUAE',
'KBaichoo': 'U016ZPU8KBK',
'wbpcode': 'U017KF5C0Q6',
'mathetake': 'UG9TD2FSB',
'RyanTheOptimist': 'U01SW3JC8GP',
}

# Only notify API reviewers who aren't maintainers.
# Maintainers are already notified of pending PRs.
API_REVIEWERS = {
Expand Down Expand Up @@ -74,19 +88,21 @@ def pr_message(pr_age, pr_url, pr_title, delta_days, delta_hours):


# Adds reminder lines to the appropriate assignee to review the assigned PRs
# Returns true if one of the assignees is in the known_assignee_map, false otherwise.
def add_reminders(assignees, assignees_and_prs, message, known_assignee_map):
has_known_assignee = False
# Returns true if one of the assignees is in the primary_assignee_map, false otherwise.
def add_reminders(
assignees, assignees_and_prs, message, primary_assignee_map, first_pass_assignee_map):
has_primary_assignee = False
for assignee_info in assignees:
assignee = assignee_info.login
if assignee not in known_assignee_map:
if assignee in primary_assignee_map:
has_primary_assignee = True
elif assignee not in first_pass_assignee_map:
continue
has_known_assignee = True
if assignee not in assignees_and_prs.keys():
assignees_and_prs[
assignee] = "Hello, %s, here are your PR reminders for the day \n" % assignee
assignees_and_prs[assignee] = assignees_and_prs[assignee] + message
return has_known_assignee
return has_primary_assignee


# Returns true if the PR needs an LGTM from an API shephard.
Expand Down Expand Up @@ -147,15 +163,15 @@ def track_prs():
message = pr_message(delta, pr_info.html_url, pr_info.title, delta_days, delta_hours)

if (needs_api_review(labels, repo, pr_info)):
add_reminders(pr_info.assignees, api_review_and_prs, message, API_REVIEWERS)
add_reminders(pr_info.assignees, api_review_and_prs, message, API_REVIEWERS, [])

# If the PR has been out-SLO for over a day, inform on-call
if delta > datetime.timedelta(hours=get_slo_hours() + 36):
stalled_prs = stalled_prs + message

# Add a reminder to each maintainer-assigner on the PR.
has_maintainer_assignee = add_reminders(
pr_info.assignees, maintainers_and_prs, message, MAINTAINERS)
pr_info.assignees, maintainers_and_prs, message, MAINTAINERS, FIRST_PASS)

# If there was no maintainer, track it as unassigned.
if not has_maintainer_assignee:
Expand Down