quiche: early fail listener config with both quic and connection_balencer#17834
Merged
ggreenway merged 2 commits intoenvoyproxy:mainfrom Aug 25, 2021
Merged
quiche: early fail listener config with both quic and connection_balencer#17834ggreenway merged 2 commits intoenvoyproxy:mainfrom
ggreenway merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
/assign @ggreenway |
ggreenway
requested changes
Aug 24, 2021
Member
ggreenway
left a comment
ggreenway
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Looks good except for one typo.
/wait
source/server/listener_impl.cc
Outdated
| #ifdef ENVOY_ENABLE_QUIC | ||
| if (config_.has_connection_balance_config()) { | ||
| throw EnvoyException("connection_balance_config is configured for QUIC listener which " | ||
| "doesn't work with connection balencer."); |
ggreenway
approved these changes
Aug 25, 2021
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Aug 25, 2021
* main: config: fix dfp config validation (envoyproxy#17835) docs: updating where meetings are uploaded (envoyproxy#17832) h2: moving a comment (envoyproxy#17846) quiche: early fail listener config with both quic and connection_balencer (envoyproxy#17834) dns: configuring a basic key value store to persist to disk (envoyproxy#17745) quic: fix receiving STOP_SENDING (envoyproxy#17815) tooling: Add Github release manager (envoyproxy#17741) tooling: Use upstream pytest-patches (envoyproxy#17809) Remove `hidden_envoy_deprecated_use_http2` (envoyproxy#17805) kafka: produce request for mesh-filter (envoyproxy#17818) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Zhang danzh@google.com
QUIC listener use BPF kernel routine for each packet to guarantee stable connection. connection_balencer in Listener config undermines this purpose. So it shouldn't be used with QUIC listener.
Risk Level: low
Testing: added unit test
Fixes #13116