Skip to content

Remove hidden_envoy_deprecated_use_http2#17805

Merged
htuch merged 1 commit intoenvoyproxy:mainfrom
tyxia:http2
Aug 25, 2021
Merged

Remove hidden_envoy_deprecated_use_http2#17805
htuch merged 1 commit intoenvoyproxy:mainfrom
tyxia:http2

Conversation

@tyxia
Copy link
Member

@tyxia tyxia commented Aug 23, 2021

Signed-off-by: Tianyu Xia tyxia@google.com

Risk Level: LOW
Testing: CI

Signed-off-by: Tianyu Xia <tyxia@google.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #17805 was opened by tyxia.

see: more, trace.

@tyxia tyxia marked this pull request as ready for review August 23, 2021 13:32
@tyxia tyxia marked this pull request as draft August 23, 2021 13:57
@tyxia tyxia marked this pull request as ready for review August 23, 2021 16:56
@tyxia
Copy link
Member Author

tyxia commented Aug 23, 2021

/assign @htuch
Somehow, this PR doesn't have auto-assigned reviewer when I make it "ready for review" from draft.
PTAL. Thanks!

@tyxia
Copy link
Member Author

tyxia commented Aug 23, 2021

/assign @htuch

re-do assignment since previous comment doesn't work

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 340430f into envoyproxy:main Aug 25, 2021
@tyxia tyxia deleted the http2 branch August 25, 2021 15:56
mpuncel added a commit to mpuncel/envoy that referenced this pull request Aug 25, 2021
* main:
  config: fix dfp config validation (envoyproxy#17835)
  docs: updating where meetings are uploaded (envoyproxy#17832)
  h2: moving a comment (envoyproxy#17846)
  quiche: early fail listener config with both quic and connection_balencer (envoyproxy#17834)
  dns: configuring a basic key value store to persist to disk (envoyproxy#17745)
  quic: fix receiving STOP_SENDING (envoyproxy#17815)
  tooling: Add Github release manager (envoyproxy#17741)
  tooling: Use upstream pytest-patches (envoyproxy#17809)
  Remove `hidden_envoy_deprecated_use_http2` (envoyproxy#17805)
  kafka: produce request for mesh-filter (envoyproxy#17818)

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants