network: rename the addressProvider() to connectionInfoProvider()#17825
Merged
mattklein123 merged 8 commits intoenvoyproxy:mainfrom Aug 26, 2021
Merged
network: rename the addressProvider() to connectionInfoProvider()#17825mattklein123 merged 8 commits intoenvoyproxy:mainfrom
mattklein123 merged 8 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
…haredPtr() Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
soulxu
requested review from
alyssawilk,
antoniovicente,
asraa,
ggreenway,
jmarantz,
lizan,
snowp and
zuercher
as code owners
Member
Author
mattklein123
requested changes
Aug 24, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thanks. One small comment.
/wait
envoy/network/connection.h
Outdated
| @@ -194,8 +194,8 @@ class Connection : public Event::DeferredDeletable, | |||
| /** | |||
| * @return the address provider backing this connection. | |||
Member
There was a problem hiding this comment.
Can you update the doc comments now on the interfaces just so we don't forget later?
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Member
Author
|
emm.. |
This reverts commit 7238382. Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Member
Author
I saw this #17846, so revert the change of lower the h2 test coverage, instead of a rebase. |
mattklein123
approved these changes
Aug 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: network: rename the addressProvider() to connectionInfoProvider()
Additional Description:
Rename the addressProvider() to connectionInfoProvider() and addressProviderSharedPtr() to connectionInfoProviderSharedPtr()
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Part of #17168
Signed-off-by: He Jie Xu hejie.xu@intel.com