ci: add linker flags to clang-asan#17773
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Aug 19, 2021
Merged
Conversation
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Augustyniak
force-pushed
the
add-link-flags
branch
from
d4247f1 to
8069480
Compare
keith
approved these changes
Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Add additional linker clang to clang-asan
Additional Description: In EnvoyMobile repo we needed to add these linker flags since without them clang-asan job was
failing with the following error:
ld.lld: error: undefined symbol: __muloti4. See this Envoy Mobile PR for more details. We worked around this error by adding the flags in.bazelrcfile in EnvoyMobile repo and want to move them to the upstream now.Risk Level: Small (used by CI only)
Testing: Already implemented and tested in Envoy-Mobile repo.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A