Merged
Conversation
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Contributor
|
Thanks @Augustyniak and @snowp! |
goaway
previously approved these changes
Aug 5, 2021
Contributor
|
FYI: The failure of |
af68d87 to
80e1a52
Compare
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Contributor
|
🤞 |
Contributor
Author
|
I need to update Envoy again since the current version of Envoy makes iOS/Android hello world application crash: Envoy issues were fixed in upstream Envoy as part of envoyproxy/envoy#17622. |
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
lfpino
pushed a commit
to lfpino/envoy-mobile
that referenced
this pull request
Aug 10, 2021
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Contributor
Author
|
Just a note about why we needed to add new linker flags as part of this PR. We needed to add: since without these additional asan job was failing with the following error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up the following changes envoyproxy/envoy@57bfbda...a82962c
There was an error:
which we were able to get rid of by updating
com_google_absldependency.Description:
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
[Optional Fixes #Issue]
[Optional Deprecated:]