Skip to content

Bump Envoy version: a82962c#1666

Merged
goaway merged 8 commits intoenvoyproxy:mainfrom
Augustyniak:bump-envoy
Aug 9, 2021
Merged

Bump Envoy version: a82962c#1666
goaway merged 8 commits intoenvoyproxy:mainfrom
Augustyniak:bump-envoy

Conversation

@Augustyniak
Copy link
Contributor

@Augustyniak Augustyniak commented Aug 5, 2021

Picking up the following changes envoyproxy/envoy@57bfbda...a82962c

There was an error:

external/envoy/source/common/buffer/watermark_buffer.cc:5:10: fatal error: 'absl/numeric/bits.h' file not found
#include "absl/numeric/bits.h"

which we were able to get rid of by updating com_google_absl dependency.

Description:
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
buildbreaker
buildbreaker previously approved these changes Aug 5, 2021
Copy link

@buildbreaker buildbreaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Augustyniak !

@goaway
Copy link
Contributor

goaway commented Aug 5, 2021

Thanks @Augustyniak and @snowp!

goaway
goaway previously approved these changes Aug 5, 2021
@ulfjack
Copy link
Contributor

ulfjack commented Aug 5, 2021

FYI: The failure of ios_build_shadow was caused by me making a change to the CI. Please ignore.

@Augustyniak Augustyniak dismissed stale reviews from goaway and buildbreaker via a0cdd54 August 6, 2021 02:58
@Augustyniak Augustyniak force-pushed the bump-envoy branch 2 times, most recently from af68d87 to 80e1a52 Compare August 6, 2021 04:46
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
@goaway
Copy link
Contributor

goaway commented Aug 6, 2021

🤞

@junr03 junr03 mentioned this pull request Aug 6, 2021
@junr03 junr03 changed the title Bump Envoy version Bump Envoy version: 79ade4a Aug 6, 2021
@Augustyniak
Copy link
Contributor Author

I need to update Envoy again since the current version of Envoy makes iOS/Android hello world application crash:

[2021-08-06 15:39:47.049][1052159][critical][assert] [external/envoy/source/server/proto_descriptors.cc:49] assert failure: Protobuf::DescriptorPool::generated_pool()->FindMessageTypeByName(type) != nullptr. Details: envoy.api.v2.Cluster

Envoy issues were fixed in upstream Envoy as part of envoyproxy/envoy#17622.

Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
@Augustyniak Augustyniak changed the title Bump Envoy version: 79ade4a Bump Envoy version: a82962c Aug 9, 2021
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Copy link
Contributor

@goaway goaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Augustyniak!

@goaway goaway merged commit 1d0f17d into envoyproxy:main Aug 9, 2021
lfpino pushed a commit to lfpino/envoy-mobile that referenced this pull request Aug 10, 2021
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
@Augustyniak
Copy link
Contributor Author

Just a note about why we needed to add new linker flags as part of this PR.

We needed to add:

build:clang-asan --linkopt --rtlib=compiler-rt
build:clang-asan --linkopt --unwindlib=libgcc

since without these additional asan job was failing with the following error:

Execution platform: @local_config_platform//:host
ld.lld: error: undefined symbol: __muloti4
>>> referenced by numbers.cc
>>>               bazel-out/k8-fastbuild/bin/external/com_google_absl/absl/strings/_objs/strings/numbers.pic.o:(absl::operator*(absl::int128, absl::int128))
clang-11: error: linker command failed with exit code 1 (use -v to see invocation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants