Split VaryHeader into VaryAllowList and VaryUtils to organize vary-related logic#17728
Merged
jmarantz merged 3 commits intoenvoyproxy:mainfrom Aug 23, 2021
Merged
Split VaryHeader into VaryAllowList and VaryUtils to organize vary-related logic#17728jmarantz merged 3 commits intoenvoyproxy:mainfrom
jmarantz merged 3 commits intoenvoyproxy:mainfrom
Conversation
…lated logic. Signed-off-by: Josiah Kiehl <josiah@capoferro.net>
capoferro
changed the title
dmitri-d
reviewed
Aug 16, 2021
Contributor
|
A small nit -- I think |
Signed-off-by: Josiah Kiehl <josiah@capoferro.net>
capoferro
commented
Aug 18, 2021
Contributor
Author
capoferro
left a comment
capoferro
left a comment
There was a problem hiding this comment.
A small nit -- I think VaryUtils is not very descriptive, perhaps VaryHeader(s) or something else that makes it clear that methods within deal with vary headers?
Utils seems to be a common thing across Envoy. Perhaps VaryHeaderUtils for the namespace name?
Signed-off-by: Josiah Kiehl <josiah@capoferro.net>
jmarantz
approved these changes
Aug 23, 2021
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Aug 25, 2021
* main: (32 commits) Stop processing pending H/2 frames if connection transitioned to the closed state http2: limit use of deferred resets in the http2 codec to server-side connections Abort filter chain iteration on local reply Reject or strip fragment from request URI ext-authz: merge duplicate headers from client request in check request common: introduce stable logger /w examples in DNS (envoyproxy#17772) route: fast return when route matches failed (envoyproxy#17769) owners: add owners for dubbo proxy network filter (envoyproxy#17820) config/router/tcp_proxy/options: v2 API, boosting and --bootstrap-version CLI removal. (envoyproxy#17724) coverage: revert the limit http/cache to 92.6. (envoyproxy#17817) network: rename SocketAddressProvider as ConnectionInfoProvider (envoyproxy#17717) test: bumping coverage (envoyproxy#17757) conn_pool: Minor cleanups to ConnPoolBaseImpl (envoyproxy#17710) Split VaryHeader into VaryAllowList and VaryUtils to organize vary-related logic (envoyproxy#17728) ext_proc: Make tests more resilient to IPv6 support (envoyproxy#17784) Remove invlaid backquote from doc (envoyproxy#17797) rocketmq: move to contrib (envoyproxy#17796) kafka: upstream kafka facade in mesh-filter (envoyproxy#17783) ecds: create shared base class for DynamicFilterConfigProviderImpl (envoyproxy#17735) Change log level from debug to trace (envoyproxy#17774) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
jmarantz
pushed a commit
that referenced
this pull request
Aug 31, 2021
Commit Message: Reviewer prefers namespaces to static classes (Envoy style guide doesn't mention this). Additional Description: This is a followup from comments in #17728 Risk Level: Very Low Testing: Existing Signed-off-by: Josiah Kiehl <josiah@capoferro.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Split VaryHeader into VaryAllowList and VaryUtils to organize vary-related logic.
Additional Description: Just a refactor.
Risk Level: Low
Testing: Existing tests
Docs Changes: None
Release Notes: N/A
Platform Specific Features: N/A