config/router/tcp_proxy/options: v2 API, boosting and --bootstrap-version CLI removal. by htuch · Pull Request #17724 · envoyproxy/envoy

htuch · 2021-08-16T01:59:39Z

This PR cleans up a bunch of v2 tech debt, including version conversion and API oracle
code:

Remove all non-trivial field references to hidden_envoy_deprecated_*. These were primarily
in tcp_proxy, router and Node build_version.
Remove boosting, hidden type annotation and the API type oracle. We are now only v3 for
both resource and transport API version.
Remove --bootstrap-version flag (all bootstraps already must be v3).

Risk level: High (It's possible there were some runtime guarded or not dependencies on
boosting).
Testing: Validated test functional coverage when removing hidden_envoy_deprecated_* field tests.
Releasing notes: TODO

Fixes #17706

Signed-off-by: Harvey Tuch htuch@google.com

…son CLI removal. This PR cleans up a bunch of v2 tech debt, including version conversion and API oracle code: * Remove all non-trivial field references to hidden_envoy_deprecated_*. These were primarily in tcp_proxy and router. * Remove boosting, hidden type annotation and the API type oracle. We are now only v3 for both resource and transport API version. * Remove --boostrap-version flag (all boostraps already must be v3). Risk level: High (It's possible there were some runtime guarded or not dependencies on boosting). Testing: Validated test functional coverage when removing hidden_envoy_deprecated_* field tests. Releasing notes: TODO Fixes envoyproxy#17706 Signed-off-by: Harvey Tuch <htuch@google.com>

htuch · 2021-08-16T02:00:42Z

Still WiP (accidentally didn't create draft), but once I have tests passing, this will be the shape of the solution to #17706 and most of the remaining v2 references in code. CC @mattklein123 @tyxia @alyssawilk @phlax

wrowe · 2021-08-17T15:26:36Z

Need to merge main, @htuch

Signed-off-by: Harvey Tuch <htuch@google.com>

repokitteh-read-only · 2021-08-23T02:10:08Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #17724 was synchronize by htuch.

see: more, trace.

Signed-off-by: Harvey Tuch <htuch@google.com>

htuch · 2021-08-23T12:50:39Z

@mattklein123 this should be ready for review now (some small fixups on coverage possible but that's it).

Signed-off-by: Harvey Tuch <htuch@google.com>

mattklein123

Amazing! So much red! Thank you so much for cleaning all of this up. 🎉

ggreenway · 2021-08-23T21:25:28Z

source/common/tcp_proxy/tcp_proxy.cc

    return drain_manager;
  });

-  if (config.has_hidden_envoy_deprecated_deprecated_v1()) {


I think there may be a bunch of dead code left in tcp_proxy after this, but I can go through and clean it up in a later PR. Very happy to see this going away finally!

Sure, please do, this PR is already huge :D

Signed-off-by: Harvey Tuch <htuch@google.com>

htuch · 2021-08-24T02:52:20Z

clang-tidy is timing out. @mattklein123 when you get a chance can you rubber stamp and force submit? Thanks.

* main: (32 commits) Stop processing pending H/2 frames if connection transitioned to the closed state http2: limit use of deferred resets in the http2 codec to server-side connections Abort filter chain iteration on local reply Reject or strip fragment from request URI ext-authz: merge duplicate headers from client request in check request common: introduce stable logger /w examples in DNS (envoyproxy#17772) route: fast return when route matches failed (envoyproxy#17769) owners: add owners for dubbo proxy network filter (envoyproxy#17820) config/router/tcp_proxy/options: v2 API, boosting and --bootstrap-version CLI removal. (envoyproxy#17724) coverage: revert the limit http/cache to 92.6. (envoyproxy#17817) network: rename SocketAddressProvider as ConnectionInfoProvider (envoyproxy#17717) test: bumping coverage (envoyproxy#17757) conn_pool: Minor cleanups to ConnPoolBaseImpl (envoyproxy#17710) Split VaryHeader into VaryAllowList and VaryUtils to organize vary-related logic (envoyproxy#17728) ext_proc: Make tests more resilient to IPv6 support (envoyproxy#17784) Remove invlaid backquote from doc (envoyproxy#17797) rocketmq: move to contrib (envoyproxy#17796) kafka: upstream kafka facade in mesh-filter (envoyproxy#17783) ecds: create shared base class for DynamicFilterConfigProviderImpl (envoyproxy#17735) Change log level from debug to trace (envoyproxy#17774) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>

- renamed `Envoy::Network::SocketAddressProvider` to `Envoy::Network::ConnectionInfoProvider` as per envoyproxy/envoy#17717. - removed a boolean argument in a call to `Envoy::MessageUtil::loadFromFile` as per envoyproxy/envoy#17724. - removing reference to and presence of the unknown proto field `Envoy::ProtobufWellKnown::OriginalTypeFieldNumber` after Envoy deleted it in envoyproxy/envoy#17724. - updated the command line in `README.md` to reflect Envoy's removal of flags related to bootstrap version. - moving Envoy configurations used in integration tests off the deprecated field `envoy.config.bootstrap.v3.Admin.access_log_path`. - no changes to `.bazelrc`, `.bazelversion`, `run_envoy_docker.sh`. Signed-off-by: Jakub Sobon <mumak@google.com>

* Drop --bootstrap-version flag envoyproxy/envoy#17724 * Update proxy version * Decouple sha update

htuch requested review from alyssawilk, ggreenway, jmarantz, mattklein123, yanavlasov and zuercher as code owners August 16, 2021 01:59

htuch changed the title ~~[WiP] config/router/tcp_proxy/options: v2 API, boosting and --boostrap-version CLI removal.~~ [WiP] config/router/tcp_proxy/options: v2 API, boosting and --bootstrap-version CLI removal. Aug 16, 2021

htuch added 2 commits August 22, 2021 16:47

Merge remote-tracking branch 'upstream/main' into remove-boost

39a20b9

Fix remaining tests.

d063559

Signed-off-by: Harvey Tuch <htuch@google.com>

htuch requested review from asraa, lizan and snowp as code owners August 23, 2021 01:11

htuch added 2 commits August 23, 2021 01:51

Fix version history.

ff1a78a

Signed-off-by: Harvey Tuch <htuch@google.com>

Fix --boostrap-version refs.

f880f27

Signed-off-by: Harvey Tuch <htuch@google.com>

repokitteh-read-only bot added the api label Aug 23, 2021

repokitteh-read-only bot assigned lizan Aug 23, 2021

htuch added 2 commits August 23, 2021 02:22

Fix options_impl_test.

de0b344

Signed-off-by: Harvey Tuch <htuch@google.com>

Lexical ordering.

a248237

Signed-off-by: Harvey Tuch <htuch@google.com>

htuch changed the title ~~[WiP] config/router/tcp_proxy/options: v2 API, boosting and --bootstrap-version CLI removal.~~ config/router/tcp_proxy/options: v2 API, boosting and --bootstrap-version CLI removal. Aug 23, 2021

htuch added 2 commits August 23, 2021 12:36

Fix compile_time_options.

012f568

Signed-off-by: Harvey Tuch <htuch@google.com>

Remove dead code impacting coverage.

75e649a

Signed-off-by: Harvey Tuch <htuch@google.com>

htuch assigned mattklein123 and unassigned lizan Aug 23, 2021

htuch mentioned this pull request Aug 23, 2021

rocketmq: fix protobuf import path #17810

Closed

Remove more dead code.

68a163c

Signed-off-by: Harvey Tuch <htuch@google.com>

Fix tests.

07a1597

Signed-off-by: Harvey Tuch <htuch@google.com>

mattklein123 previously approved these changes Aug 23, 2021

View reviewed changes

repokitteh-read-only bot removed the api label Aug 23, 2021

ggreenway reviewed Aug 23, 2021

View reviewed changes

htuch added 2 commits August 23, 2021 23:55

Merge remote-tracking branch 'upstream/main' into remove-boost

33f95ce

Tweak borderline coverage.

1d93126

Signed-off-by: Harvey Tuch <htuch@google.com>

htuch dismissed mattklein123’s stale review via 1d93126 August 23, 2021 23:57

repokitteh-read-only bot added the api label Aug 23, 2021

alyssawilk approved these changes Aug 24, 2021

View reviewed changes

alyssawilk merged commit d142c9d into envoyproxy:main Aug 24, 2021

mum4k mentioned this pull request Aug 31, 2021

Update Envoy to 74d5ef8 (Aug 30th 2021). envoyproxy/nighthawk#740

Merged

sergii-ssh added a commit to sergii-ssh/istio that referenced this pull request Sep 8, 2021

Drop --bootstrap-version flag envoyproxy/envoy#17724

c338273

sergii-ssh mentioned this pull request Sep 8, 2021

Drop --bootstrap-version flag istio/istio#35070

Merged

9 tasks

istio-testing pushed a commit to istio/istio that referenced this pull request Sep 9, 2021

Drop --bootstrap-version flag (#35070)

34a1828

* Drop --bootstrap-version flag envoyproxy/envoy#17724 * Update proxy version * Decouple sha update

htuch mentioned this pull request Sep 12, 2021

Remove --bootstrap-version command line option #16456

Closed

sergii-ssh added a commit to sergii-ssh/istio that referenced this pull request Sep 27, 2021

Drop --bootstrap-version flag (istio#35070)

2492701

* Drop --bootstrap-version flag envoyproxy/envoy#17724 * Update proxy version * Decouple sha update

sergii-ssh mentioned this pull request Sep 27, 2021

[Cherry-pick] Drop --bootstrap-version flag (#35070) istio/istio#35389

Closed

10 tasks

voisey mentioned this pull request Apr 21, 2022

chore: update envoy config file to use API v3 magma/magma#12510

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

config/router/tcp_proxy/options: v2 API, boosting and --bootstrap-version CLI removal.#17724

config/router/tcp_proxy/options: v2 API, boosting and --bootstrap-version CLI removal.#17724
alyssawilk merged 13 commits intoenvoyproxy:mainfrom
htuch:remove-boost

htuch commented Aug 16, 2021 •

edited

Loading

Uh oh!

htuch commented Aug 16, 2021

Uh oh!

wrowe commented Aug 17, 2021

Uh oh!

repokitteh-read-only bot commented Aug 23, 2021

Uh oh!

htuch commented Aug 23, 2021

Uh oh!

mattklein123 left a comment

Uh oh!

ggreenway Aug 23, 2021

Uh oh!

htuch Aug 24, 2021

Uh oh!

htuch commented Aug 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

htuch commented Aug 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

htuch commented Aug 16, 2021

Uh oh!

wrowe commented Aug 17, 2021

Uh oh!

repokitteh-read-only bot commented Aug 23, 2021

Uh oh!

htuch commented Aug 23, 2021

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

ggreenway Aug 23, 2021

Choose a reason for hiding this comment

Uh oh!

htuch Aug 24, 2021

Choose a reason for hiding this comment

Uh oh!

htuch commented Aug 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

htuch commented Aug 16, 2021 •

edited

Loading