bazel: update golang and rules_go by keith · Pull Request #17438 · envoyproxy/envoy

keith · 2021-07-21T18:27:11Z

These updates are required for things to work nicely when building on
Apple Silicon machines targeting darwin_arm64.

Risk Level: Low

repokitteh-read-only · 2021-07-21T18:27:14Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #17438 was opened by keith.

see: more, trace.

repokitteh-read-only · 2021-07-21T18:27:17Z

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #17438 was opened by keith.

see: more, trace.

htuch

LGTM, thanks!

keith · 2021-07-22T02:21:27Z

hrm failure is related but not seeing any details in the log, will have to look later

bazel/repository_locations.bzl

moderation · 2021-07-22T03:57:39Z

/lgtm deps

moderation · 2021-08-05T00:29:26Z

/lgtm deps

htuch · 2021-08-09T13:34:08Z

The Go build in linux_x64 api is still failing.
/wait

keith · 2021-08-12T20:28:39Z

Hoping #17082 helps us out here

github-actions · 2021-09-12T00:02:05Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

keith · 2021-09-12T01:39:31Z

still blocked on the linked PR, but still important

keith · 2021-09-21T22:31:41Z

Oops that linked the issue, this is the actual PR #17460

htuch · 2021-09-22T02:03:07Z

Seems still broken on API build.
/wait

aneeshusa · 2021-09-27T16:56:22Z

bazel/dependency_imports.bzl

Go 1.17 is now out (latest is Go 1.17.1: https://golang.org/dl/), any chance we can try updating to that? Hopefully a drop-in in this PR but can make it a follow-up PR if needed.

Typically the rules_go release updates were very close to Go releases. That seems to have stopped with 0.28.0

FWIW, my read of bazel-contrib/rules_go#2729 is that it should no longer be required to update rules_go for every new Go release.

Interesting. We we need to continue to set the Go version to get reproducible builds (and to stop a potential breakage as the Go version increment in the background). So the changes to rules_go 0.28.0 and bazel-gazelle to 0.23.0 LGTM. We should bump the Go version on line 14 to 1.17.1 (I've been running this setup locally since 1.17 came out

I did the minimum bump required to get M1 support at the time I submitted this PR just to keep this change as small as possible, happy to bump more, it will probably be fine

bazel/repository_locations.bzl

These updates are required for things to work nicely when building on Apple Silicon machines targeting darwin_arm64. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

github-actions · 2021-12-02T00:01:59Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

remyleone · 2021-12-02T07:37:30Z

@keith any update on this?

keith · 2021-12-02T18:52:19Z

It is now part of #17460 I just want to make sure that lands so we don't forget about it

keith · 2021-12-03T18:10:21Z

#17460

repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jul 21, 2021

keith force-pushed the ks/bazel-update-golang-and-rules_go branch 3 times, most recently from 81a85c2 to d24279e Compare July 21, 2021 18:48

keith marked this pull request as ready for review July 21, 2021 19:59

keith mentioned this pull request Jul 22, 2021

Envoy on Apple silicon m1 #16482

Closed

keith force-pushed the ks/bazel-update-golang-and-rules_go branch from f168fd0 to 0ace424 Compare July 22, 2021 00:24

htuch previously approved these changes Jul 22, 2021

View reviewed changes

htuch self-assigned this Jul 22, 2021

moderation reviewed Jul 22, 2021

View reviewed changes

bazel/repository_locations.bzl Outdated Show resolved Hide resolved

repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jul 22, 2021

mattklein123 added the waiting label Jul 22, 2021

keith dismissed htuch’s stale review via f0c2c1f August 4, 2021 23:08

keith force-pushed the ks/bazel-update-golang-and-rules_go branch from 0ace424 to f0c2c1f Compare August 4, 2021 23:08

repokitteh-read-only bot added deps Approval required for changes to Envoy's external dependencies and removed waiting labels Aug 4, 2021

keith force-pushed the ks/bazel-update-golang-and-rules_go branch 2 times, most recently from acca0b7 to 7a59721 Compare August 5, 2021 00:23

repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Aug 5, 2021

repokitteh-read-only bot added the waiting label Aug 9, 2021

github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Sep 12, 2021

github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Sep 12, 2021

keith force-pushed the ks/bazel-update-golang-and-rules_go branch from 7a59721 to da44933 Compare September 21, 2021 22:32

repokitteh-read-only bot added deps Approval required for changes to Envoy's external dependencies and removed waiting labels Sep 21, 2021

repokitteh-read-only bot added the waiting label Sep 22, 2021

keith mentioned this pull request Sep 22, 2021

protos: add support for go_option package #17460

Merged

aneeshusa reviewed Sep 27, 2021

View reviewed changes

moderation mentioned this pull request Oct 6, 2021

[WIP] deps: Bump io_bazel_rules_go -> 0.28.0 #18472

Closed

codefromthecrypt mentioned this pull request Oct 7, 2021

Envoy 1.20 Homebrew/homebrew-core#86755

Closed

6 tasks

phlax reviewed Oct 7, 2021

View reviewed changes

bazel/repository_locations.bzl Outdated Show resolved Hide resolved

keith marked this pull request as draft October 7, 2021 18:58

phlax mentioned this pull request Oct 8, 2021

Newer release available io_bazel_rules_go: v0.29.0 (current: v0.27.0) #18497

Closed

bazel: update golang and rules_go

82e5eef

These updates are required for things to work nicely when building on Apple Silicon machines targeting darwin_arm64. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

keith force-pushed the ks/bazel-update-golang-and-rules_go branch from da44933 to 82e5eef Compare November 1, 2021 22:29

repokitteh-read-only bot removed the waiting label Nov 1, 2021

github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 2, 2021

github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Dec 2, 2021

phlax added the no stalebot Disables stalebot from closing an issue label Dec 2, 2021

keith closed this Dec 3, 2021

keith deleted the ks/bazel-update-golang-and-rules_go branch December 3, 2021 18:10

Conversation

keith commented Jul 21, 2021 • edited by phlax Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Jul 21, 2021

Uh oh!

repokitteh-read-only bot commented Jul 21, 2021

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

keith commented Jul 22, 2021

Uh oh!

Uh oh!

moderation commented Jul 22, 2021

Uh oh!

moderation commented Aug 5, 2021

Uh oh!

htuch commented Aug 9, 2021

Uh oh!

keith commented Aug 12, 2021

Uh oh!

github-actions bot commented Sep 12, 2021

Uh oh!

keith commented Sep 12, 2021

Uh oh!

keith commented Sep 21, 2021

Uh oh!

htuch commented Sep 22, 2021

Uh oh!

aneeshusa Sep 27, 2021

Choose a reason for hiding this comment

Uh oh!

moderation Sep 27, 2021

Choose a reason for hiding this comment

Uh oh!

aneeshusa Sep 27, 2021

Choose a reason for hiding this comment

Uh oh!

moderation Sep 27, 2021

Choose a reason for hiding this comment

Uh oh!

keith Sep 29, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Dec 2, 2021

Uh oh!

remyleone commented Dec 2, 2021

Uh oh!

keith commented Dec 2, 2021

Uh oh!

keith commented Dec 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

keith commented Jul 21, 2021 •

edited by phlax

Loading