protos: add support for go_option package

[remyleone]

Hello, I would like first to see if this change is desired before specifying the go_package option in all the files. If so, I will gladly specify it everywhere. :)

For reference when I use envoy in buf I get the following warnings:

2021/07/23 09:46:05 WARNING: Missing 'go_package' option in "envoy/api/v2/core/socket_option.proto",
please specify it with the full Go package path as
a future release of protoc-gen-go will require this be specified.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

#17082

[repokitteh-read-only]

Hi @remyleone, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #17460 was opened by remyleone.

see: more, trace.

[repokitteh-read-only]

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy[\w/]*/(v1alpha\d?|v1|v2alpha\d?|v2))|(api/envoy/type/(matcher/)?\w+.proto).
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #17460 was opened by remyleone.

see: more, trace.

[kyessenov]

I think we need this now. go_package appears to be mandatory from now on (talk about v1 stability!). I think this can be a mechanical sed operation to do a global pass, and then we can institute a linter rule requiring go_package. Are you OK with doing the pass? If not, I might have to find some time to do that.

[remyleone]

@kyessenov I'm ok to do a pass, how can the linter rule be implemented?

[remyleone]

@kyessenov pass done. How can we check it up with a linter?

[yanavlasov]

Thanks you for doing this forklift change. I think the linter needs to be fixed here:

envoy/tools/protoxform/protoprint.py

Line 206 in 79ade4a

options = descriptor_pb2.FileOptions()

to add go_package option. You can see how it is done for java.

[yanavlasov]

/wait

[remyleone]

@yanavlasov done in envoy/tools/protoxform/protoprint.py :)

[kyessenov]

Thanks for the massive cleanup. There's a syntax linter in python script that needs a fix, but otherwise, everything LGTM.

[markdroth]

/lgtm api
/lgtm v2-freeze

[remyleone]

@kyessenov fixed :)

[remyleone]

I think the script ./ci/format_pre.sh cannot be launch from local. I've tried ENVOY_SRCDIR=. ./ci/format_pre.sh but it does not seem to work. I've just run yapf in place and it seems to pass in local

[keith]

Can you try running just the proto formatter locally? ./tools/proto_format/proto_format.sh fix

[yanavlasov]

/wait

[remyleone]

@keith done :) It modified a lot of files in generated_api_shadow and in API. Is this command documented somewhere?

[keith]

Hrm looks like formatting failed just for 3 files this time, maybe for unrelated changes. I guess it might be ideal if you could only update the format of the files you intentionally changed, but I'm not sure how folks normally do this if others did need updates. Regardless maybe you can fix those 3 files and be good here?

I'm not sure if it's documented or what the normal workflow is here I just found that in the script you tried to run and am hoping that should be all we need

[keith]

So this looks like an actually related failure?

[phlax]

hi @remyleone looks like this will need a rebase

[repokitteh-read-only]

🙀 Error while processing event:

evaluation error
error: context deadline exceeded

🐱

Caused by: a #17460 (comment) was created by @markdroth.

see: more, trace.

[keith]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17460 (comment) was created by @keith.

see: more, trace.

[kyessenov]

Thanks for slogging through all the protos.

[mattklein123]

Yay!

[remyleone]

Thanks a lot for the reviews and patience :)

[keith]

Thanks for all the hard work everyone!