tools: adding reminders for API shephards#17081
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
LGTM otherwise! I was battling a bit with commenting "why not let track_pr() return a single map of people to remind instead of one for all PRs/one for API PRs", but I think this is fine for separabilitiy
| message = pr_message(delta, pr_info.html_url, pr_info.title, delta_days, delta_hours) | ||
|
|
||
| if (needs_api_review(labels, repo, pr_info)): | ||
| add_reminders(pr_info.assignees, api_review_and_prs, message, API_REVIEWERS) |
There was a problem hiding this comment.
is it ever the case that an api PRs are unassigned? I'm pretty sure repokitteh handles that by random assignment anyway though.. so i think that's ok
There was a problem hiding this comment.
Yeah, it should always be assigned but we could arguably find it not having an API reviewer if someone removed themselves for vacation. We could have a list for unassigned_api - I'll consider it as a feature if it ever happens or @envoyproxy/api-shepherds tell me it's worth it :-)
|
|
||
| # Return the dict of {maintainers : PR notifications}, and stalled PRs | ||
| return maintainers_and_prs, stalled_prs | ||
| return maintainers_and_prs, api_review_and_prs, stalled_prs |
There was a problem hiding this comment.
might want to update the comment about this with the return val, but non-blocking
There was a problem hiding this comment.
Good call - will do in a follow-up, as it's late to do today and I'd like to get the blocking bits checked in before tomorrow's run :-)
…bridge-stream * upstream/main: (268 commits) tools: adding dio,better comments (envoyproxy#17104) doc: fix misplaced #[extension-category] for Wasm runtimes (envoyproxy#17078) ci: Speedup deps precheck (envoyproxy#17102) doc: fix wrong link on wasm network filter. (envoyproxy#17079) docs: Added v3 API reference. (envoyproxy#17095) docs: Update include paths in repo (envoyproxy#17098) exception: make Ipv6Instance and Ipv4Instance not throw and remove some try catch pattern (envoyproxy#16122) tools: adding reminders for API shephards (envoyproxy#17081) ci: Fix wasm verify example (envoyproxy#17086) [fuzz]: fix oss fuzz bug 34515, limit maglev table size (envoyproxy#16671) test: silencing flaky test (envoyproxy#17084) Set `validate` flag when the SAN(SubjectAltName) matching is performed (envoyproxy#16816) Listener: reset the file event when destroying listener filters (envoyproxy#16952) docs: link additional filters that emit dynamic metadata (envoyproxy#17059) rds: add config reload time stat for rds (envoyproxy#17033) bazel: Use color by default for build and run commands (envoyproxy#17077) ci: Add timing for docker pull (envoyproxy#17074) [Windows] Adding note section in Original Source HTTP Filter (envoyproxy#17058) quic: add quic version counters in http3 codec stats. (envoyproxy#16943) quiche: change crypto stream factory interfaces (envoyproxy#17046) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: chris.xin <xinchuantao@qq.com>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
3 participants
Doing daily digests for non-maintainer-shephards where the PR is 1) not a draft and 2) needs API LGTM ('pending' status)
cc @markdroth @adisuissa