quiche: change crypto stream factory interfaces#17046
Merged
alyssawilk merged 3 commits intoenvoyproxy:mainfrom Jun 22, 2021
Merged
quiche: change crypto stream factory interfaces#17046alyssawilk merged 3 commits intoenvoyproxy:mainfrom
alyssawilk merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
danzh2010
requested review from
alyssawilk,
ggreenway and
mattklein123
as code owners
alyssawilk
previously approved these changes
Jun 21, 2021
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
code LGTM, though you should either retest or otherwise check out coverage and ping back?
Also, optionally, you may want to add a comment somewhere in here that while these aren't used locally they're used "downstream" otherwise someone may clean it up and break our merge.
/wait
Contributor
Author
done |
alyssawilk
approved these changes
Jun 21, 2021
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
LGTM. ping back when CI is green if I haven't merged first :-)
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Jun 23, 2021
…bridge-stream * upstream/main: (268 commits) tools: adding dio,better comments (envoyproxy#17104) doc: fix misplaced #[extension-category] for Wasm runtimes (envoyproxy#17078) ci: Speedup deps precheck (envoyproxy#17102) doc: fix wrong link on wasm network filter. (envoyproxy#17079) docs: Added v3 API reference. (envoyproxy#17095) docs: Update include paths in repo (envoyproxy#17098) exception: make Ipv6Instance and Ipv4Instance not throw and remove some try catch pattern (envoyproxy#16122) tools: adding reminders for API shephards (envoyproxy#17081) ci: Fix wasm verify example (envoyproxy#17086) [fuzz]: fix oss fuzz bug 34515, limit maglev table size (envoyproxy#16671) test: silencing flaky test (envoyproxy#17084) Set `validate` flag when the SAN(SubjectAltName) matching is performed (envoyproxy#16816) Listener: reset the file event when destroying listener filters (envoyproxy#16952) docs: link additional filters that emit dynamic metadata (envoyproxy#17059) rds: add config reload time stat for rds (envoyproxy#17033) bazel: Use color by default for build and run commands (envoyproxy#17077) ci: Add timing for docker pull (envoyproxy#17074) [Windows] Adding note section in Original Source HTTP Filter (envoyproxy#17058) quic: add quic version counters in http3 codec stats. (envoyproxy#16943) quiche: change crypto stream factory interfaces (envoyproxy#17046) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo
pushed a commit
to chrisxrepo/envoy
that referenced
this pull request
Jul 8, 2021
Commit Message: pass dispatcher and transport socket factory into createEnvoyQuicCryptoServerStream(). These two parameters are not used in the default extension, but can be used for other extensions if needed. Risk Level: low Testing: existing test Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Commit Message: pass dispatcher and transport socket factory into createEnvoyQuicCryptoServerStream(). These two parameters are not used in the default extension, but can be used for other extensions if needed. Risk Level: low Testing: existing test Signed-off-by: Dan Zhang <danzh@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: pass dispatcher and transport socket factory into createEnvoyQuicCryptoServerStream(). These two parameters are not used in the default extension, but can be used for other extensions if needed.
Risk Level: low
Testing: existing test