remove v2 support for hosts from logical_dns_cluster.cc#17023
Closed
ankatare wants to merge 2 commits intoenvoyproxy:mainfrom
Closed
remove v2 support for hosts from logical_dns_cluster.cc#17023ankatare wants to merge 2 commits intoenvoyproxy:mainfrom
ankatare wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Member
|
This seems to be an empty PR(i.e. no file changes)? |
Contributor
Author
|
@tyxia This is my bad :( . i worked on PR without fetching latest code from upstream and that's why while fixing build error it all reverted back and sync with latest codebase so empty. |
Contributor
Author
|
closing as already done !!! |
Member
No worries at all. Thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhay Narayan Katare abhay.katare@india.nec.com
Commit Message: remove v2 support of hosts from logical_dns_cluster
Additional Description: PR of type remove_v2_support. first PR is #16274
Risk Level:LOW
Testing: Unit
Docs Changes: NA
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]