doc: keep code snippets in docs synchronize with implementation#16838
Merged
yanavlasov merged 2 commits intoenvoyproxy:mainfrom Jun 9, 2021
Merged
doc: keep code snippets in docs synchronize with implementation#16838yanavlasov merged 2 commits intoenvoyproxy:mainfrom
yanavlasov merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: qinggniq <livewithblank@gmail.com>
Contributor
|
Thank you for cleaning up the doc. I missed this in my PR. Looks like there are still some problems here: https://dev.azure.com/cncf/envoy/_build/results?buildId=78048&view=logs&j=55bc2ab9-36c1-5ab8-58a6-8c258728eeff&t=33b57bf9-ef13-58c8-bc2b-f804aeb16d39&l=77 |
Contributor
|
/wait |
Signed-off-by: qinggniq <livewithblank@gmail.com>
yanavlasov
approved these changes
Jun 9, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…yproxy#16838) Signed-off-by: qinggniq <livewithblank@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qinggniq livewithblank@gmail.com
After the pull #16711, the code snippets in docs need to be updated.
Commit Message: doc: keep code snippets in docs synchronize with implementation
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]