build: modify include paths to be more bazel friendly#16711
Merged
mattklein123 merged 15 commits intoenvoyproxy:mainfrom Jun 4, 2021
Merged
build: modify include paths to be more bazel friendly#16711mattklein123 merged 15 commits intoenvoyproxy:mainfrom
mattklein123 merged 15 commits intoenvoyproxy:mainfrom
Conversation
yanavlasov
requested review from
PiotrSikora,
Shikugawa,
alyssawilk,
antoniovicente,
asraa,
cpakulski,
ggreenway,
htuch,
jmarantz,
junr03,
lambdai,
lizan,
mattklein123,
snowp and
zuercher
as code owners
Member
|
Cool! Thanks for looking into making things less magic with includes. For at least the |
Contributor
|
I like |
Contributor
|
totally didn't mean to do that. |
Contributor
|
eh, while I don't like changing 1000 paths, I like source vs include. If we're going to move files I'd be inclined to nix the envoy and have source paths reflect include paths (include/common/http) but that's probably too much of a pain |
This reverts commit 02ada9a.
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
yanavlasov
changed the title
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
mattklein123
approved these changes
Jun 4, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for slogging through this.
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Yan Avlasov <yavlasov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Make Envoy include structure more bazel friendly to make it possible to build Envoy using gcc toolchain.
Risk Level: Low (but it will break external repos that depend on Envoy)
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Fixes #16196