Skip to content

Patch flaky VeryLargeRequestHeadersRejected test #16664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanavlasov merged 2 commits into from
May 26, 2021
Merged

Patch flaky VeryLargeRequestHeadersRejected test #16664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f2658e
Patch flaky VeryLargeRequestHeadersRejected test
May 25, 2021
eaa5410
fix format
May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/integration/http_integration.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,7 +1150,7 @@ void HttpIntegrationTest::testLargeRequestUrl(uint32_t url_size, uint32_t max_he

if (downstream_protocol_ == Http::CodecClient::Type::HTTP1) {
ASSERT_TRUE(codec_client_->waitForDisconnect());
EXPECT_TRUE(response->complete());
ASSERT_TRUE(response->complete());
EXPECT_EQ("431", response->headers().Status()->value().getStringView());
} else {
ASSERT_TRUE(response->waitForReset());
Expand Down Expand Up @@ -1199,7 +1199,7 @@ void HttpIntegrationTest::testLargeRequestHeaders(uint32_t size, uint32_t count,

if (downstream_protocol_ == Http::CodecClient::Type::HTTP1) {
ASSERT_TRUE(codec_client_->waitForDisconnect());
EXPECT_TRUE(response->complete());
ASSERT_TRUE(response->complete());
EXPECT_EQ("431", response->headers().getStatusValue());
} else {
ASSERT_TRUE(response->waitForReset());
Expand Down
7 changes: 5 additions & 2 deletions test/integration/protocol_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1569,8 +1569,11 @@ TEST_P(DownstreamProtocolIntegrationTest, LargeRequestHeadersRejected) {
}

TEST_P(DownstreamProtocolIntegrationTest, VeryLargeRequestHeadersRejected) {
// Send one very large 2048 kB (2 MB) header with limit 1024 kB (1 MB) and 100 headers.
testLargeRequestHeaders(2048, 1, 1024, 100);
// Send one very large 600 kB header with limit 500 kB and 100 headers.
// The limit and the header size are set in such a way to accommodate for flow control limits.
// If the headers are too large and the flow control blocks the response is truncated and the test
// flakes.
testLargeRequestHeaders(600, 1, 500, 100);
}

TEST_P(DownstreamProtocolIntegrationTest, LargeRequestHeadersAccepted) {
Expand Down