Patch flaky VeryLargeRequestHeadersRejected test#16664
Merged
yanavlasov merged 2 commits intoenvoyproxy:mainfrom May 26, 2021
Merged
Patch flaky VeryLargeRequestHeadersRejected test#16664yanavlasov merged 2 commits intoenvoyproxy:mainfrom
yanavlasov merged 2 commits intoenvoyproxy:mainfrom
Conversation
As discussed in envoyproxy#16214 there is a case when flow control blocks and as a result the reponse gets truncated. To deflake the test we reduce the size of the headers and the limit. Validated with no flakes in 10k test runs. Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
Author
|
Note that this a remedy and not a complete fix. But since the test is flaking quite a bit and creates noise, I think the remedy adds value. I think it will be good to have a follow up issue for the actual root cause |
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Contributor
Were you able to measure the original flake rate? |
Member
Author
I don't have the actual number but it was almost every time (70%+) |
antoniovicente
approved these changes
May 26, 2021
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Changes look good. Waiting for successful CI run.
Thanks for helping reduce flaky test rates.
yanavlasov
approved these changes
May 26, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
As discussed in envoyproxy#16214 there is a case when flow control blocks and as a result the reponse gets truncated. To deflake the test we reduce the size of the headers and the limit. Validated with no flakes in 10k test runs. Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
As discussed in #16214 there is a case when flow control blocks and
as a result the reponse gets truncated.
To deflake the test we reduce the size of the headers and the limit.
Validated with no flakes in 10k test runs.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com