http3: stats and stats docs.#16600
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
/wait |
|
|
||
| /** | ||
| * All stats for the HTTP/3 codec. @see stats_macros.h | ||
| * TODO(danzh) populate all of them in codec. |
There was a problem hiding this comment.
Do we have to remove these? I planned to populate them gradually.
There was a problem hiding this comment.
I don't think leaving them in the code base while they're not being used makes sense, but I think it'd be fine to add them back (and doc them up) as they're implemented.
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for the improvements to stats and docs.
| `downstream_rq_active` gauge due to differences in stream accounting between the codec and the | ||
| HTTP connection manager. | ||
|
|
||
| Http3 codec statistics |
There was a problem hiding this comment.
I think that the difference in HTTP2 and HTTP3 stats point at missing functionality in the HTTP3 codec. For example, no stats for header_overflow, inbound_window_update_frames_flood, keepalive_timeout and streams_active hint at lower level of hardening options or lack of stats to observe the behavior of those protections.
Worth thinking which of these are relevant and how to track their absense.
Adding HTTP/3 stream reset stats Removing a bunch of unused HTTP/3 stats. Doccing up the stats which exist and adding tests. While I'm in there, adding scope strings to the test client and test server, so it's easier to differentiate which stats are Envoy's vs test code. Also changing wait for counter calls to not do infinite waits. Risk Level: Low (http/3 stats addition) Testing: new integration tests Docs Changes: documenting HTT/3 stats Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
3 participants
Adding HTTP/3 stream reset stats
Removing a bunch of unused HTTP/3 stats.
Doccing up the stats which exist and adding tests.
While I'm in there, adding scope strings to the test client and test server, so it's easier to differentiate which stats are Envoy's vs test code.
Also changing wait for counter calls to not do infinite waits.
Risk Level: Low (http/3 stats addition)
Testing: new integration tests
Docs Changes: documenting HTT/3 stats
Release Notes: n/a