Skip to content

coverage: bumping numbers #16522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wrowe merged 1 commit into from
May 18, 2021
Merged

coverage: bumping numbers #16522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions test/per_file_coverage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,17 @@ declare -a KNOWN_LOW_COVERAGE=(
"source/common/common:96.3"
"source/common/common/posix:94.1"
"source/common/crypto:0.0"
"source/common/event:93.4" # Emulated edge events guards don't report LCOV
"source/common/event:94.2" # Emulated edge events guards don't report LCOV
"source/common/filesystem/posix:96.2"
"source/common/http/http3:93.9"
"source/common/json:90.9"
"source/common/network:95.0" # Flaky, `activateFileEvents`, `startSecureTransport` and `ioctl` do not always report LCOV
"source/common/protobuf:94.8"
"source/common/signal:84.5" # Death tests don't report LCOV
"source/common/singleton:95.1"
"source/common/thread:0.0" # Death tests don't report LCOV
"source/common/matcher:93.3"
"source/common/quic:87.4"
"source/common/tracing:94.9"
"source/common/quic:88.4"
"source/common/tracing:95.7"
Copy link
Copy Markdown
Contributor

@wrowe wrowe May 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out 88.4 was too high... see line 17696... https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/76091/logs/157

Copy link
Copy Markdown
Contributor Author

@alyssawilk alyssawilk May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't at the time, it was a merge conflict with #16534 which disabled tests for the coverage build.
Have PRs out to fix though!

"source/common/watchdog:42.9" # Death tests don't report LCOV
"source/exe:94.3"
"source/extensions/common/crypto:91.5"
Expand Down Expand Up @@ -52,18 +51,18 @@ declare -a KNOWN_LOW_COVERAGE=(
"source/extensions/tracers:96.4"
"source/extensions/tracers/opencensus:91.6"
"source/extensions/tracers/xray:94.0"
"source/extensions/transport_sockets:95.6"
"source/extensions/transport_sockets:95.7"
"source/extensions/transport_sockets/tls/cert_validator:96.5"
"source/extensions/transport_sockets/tls/private_key:76.9"
"source/extensions/transport_sockets/tls:95.0"
"source/extensions/transport_sockets/tls:95.1"
"source/extensions/wasm_runtime:50.0"
"source/extensions/wasm_runtime/wasmtime:0.0" # Not enabled in coverage build
"source/extensions/wasm_runtime/wavm:0.0" # Not enabled in coverage build
"source/extensions/watchdog:85.7" # Death tests within extensions
"source/extensions/watchdog/profile_action:85.7"
"source/server:94.4" # flaky: be careful adjusting. See https://github.com/envoyproxy/envoy/issues/15239
"source/server/admin:95.7"
"source/server/config_validation:75.6"
"source/server/config_validation:78.2"
)

[[ -z "${SRCDIR}" ]] && SRCDIR="${PWD}"
Expand Down