Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
ping! |
wrowe
reviewed
May 18, 2021
Contributor
wrowe
left a comment
wrowe
left a comment
There was a problem hiding this comment.
Please follow this on with a redux to quic, to at least 88.2
| "source/common/quic:87.4" | ||
| "source/common/tracing:94.9" | ||
| "source/common/quic:88.4" | ||
| "source/common/tracing:95.7" |
Contributor
There was a problem hiding this comment.
Turns out 88.4 was too high... see line 17696... https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/76091/logs/157
Contributor
Author
There was a problem hiding this comment.
It wasn't at the time, it was a merge conflict with #16534 which disabled tests for the coverage build.
Have PRs out to fix though!
ntgsx92
pushed a commit
to ntgsx92/envoy
that referenced
this pull request
May 18, 2021
Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Sixiang Gu <sgu@twitter.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: low risk of CI breakage (races)
Testing: tested against main coverage builds
Docs Changes: n/a