Skip to content

build: fix crash in pre-commit-hooks #16505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phlax merged 1 commit into from
May 17, 2021
Merged

build: fix crash in pre-commit-hooks #16505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tools/code_format/check_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,11 +323,15 @@ def read_file(self, path):
# look_path searches for the given executable in all directories in PATH
# environment variable. If it cannot be found, empty string is returned.
def look_path(self, executable):
if executable is None:
return ''
return shutil.which(executable) or ''

# path_exists checks whether the given path exists. This function assumes that
# the path is absolute and evaluates environment variables.
def path_exists(self, executable):
if executable is None:
return False
return os.path.exists(os.path.expandvars(executable))

# executable_by_others checks whether the given path has execute permission for
Expand Down