build: fix crash in pre-commit-hooks#16505
build: fix crash in pre-commit-hooks#16505phlax merged 1 commit intoenvoyproxy:mainfrom greymatter-io:build_tools
Conversation
Signed-off-by: Justin Ely <justincely@gmail.com>
|
Hi @justincely, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
hi @justincely i have a longer PR to address this here #15811 - ill check this PR over in the meantime as its pretty annoying atm |
|
@phlax thanks! I didn't realize someone else was working on anything similar, so just let me know if i'm on the wrong track or if this is superfluous considering yours. Just seemed low hanging fruit |
phlax
left a comment
There was a problem hiding this comment.
lgtm - it does the same thing as now in terms of pushing but is more likely to provide info on how to resolve and not python stacktrace
thanks @justincely
|
/retest |
|
Retrying Azure Pipelines: |
…mit hook (envoyproxy#16505) Signed-off-by: Justin Ely <justincely@gmail.com> Signed-off-by: Sixiang Gu <sgu@twitter.com>
…mit hook (envoyproxy#16505) Signed-off-by: Justin Ely <justincely@gmail.com>
Signed-off-by: Justin Ely justincely@gmail.com
Commit Message: add defensive coding against None in pre-commit hook
Additional Description: Fixes #16504
Risk Level: low
Testing: After fixing, was able to run
git pushand have the pre-commit hook spit out the right errors rather than python stacktrace.Docs Changes: None
Release Notes: None
Platform Specific Features: None
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]