Skip to content

build: Avoid use of fastbuild when building with gcc to work around command line limit #16492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
antoniovicente wants to merge 5 commits into from
Closed

build: Avoid use of fastbuild when building with gcc to work around command line limit #16492

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66e60e5
build: Avoid use of fastbuild when building with gcc to work around c…
antoniovicente May 14, 2021
a729d09
also build binary in dbg
antoniovicente May 14, 2021
9bc5936
Merge remote-tracking branch 'upstream/main' into gcc_dbg
antoniovicente May 14, 2021
fb474dd
Merge remote-tracking branch 'upstream/main' into gcc_dbg
antoniovicente May 20, 2021
60db287
Merge remote-tracking branch 'upstream/main' into gcc_dbg
antoniovicente May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/do_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,10 @@ elif [[ "$CI_TARGET" == "bazel.gcc" ]]; then
setup_gcc_toolchain

echo "Testing ${TEST_TARGETS[*]}"
bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" -c fastbuild "${TEST_TARGETS[@]}"
bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" -c dbg "${TEST_TARGETS[@]}"

echo "bazel release build with gcc..."
bazel_binary_build fastbuild
bazel_binary_build release

@yanavlasov yanavlasov May 14, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do dbg as well. Otherwise it is full rebuild again.

@antoniovicente antoniovicente May 14, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.

@PiotrSikora PiotrSikora May 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if we used -c dbg, since there are no debug builds done on the CI (...well, there is an ASan build with -c dbg, but a lot of projects turn off certain features in builds with sanitizers to avoid false-positives), and there were a few issues in the past that would have been caught by it.

@antoniovicente antoniovicente May 15, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Rolled back the switch to release, I'll wait for the review of #16132 to complete.

exit 0
elif [[ "$CI_TARGET" == "bazel.debug" ]]; then
setup_clang_toolchain
Expand Down