build: Avoid use of fastbuild when building with gcc to work around command line limit by antoniovicente · Pull Request #16492 · envoyproxy/envoy

antoniovicente · 2021-05-14T01:18:57Z

…ommand line limit Signed-off-by: Antonio Vicente <avd@google.com>

yanavlasov · 2021-05-14T01:27:06Z

ci/do_ci.sh


  echo "bazel release build with gcc..."
-  bazel_binary_build fastbuild
+  bazel_binary_build release


We should do dbg as well. Otherwise it is full rebuild again.

Sure, done.

I'd prefer if we used -c dbg, since there are no debug builds done on the CI (...well, there is an ASan build with -c dbg, but a lot of projects turn off certain features in builds with sanitizers to avoid false-positives), and there were a few issues in the past that would have been caught by it.

Makes sense. Rolled back the switch to release, I'll wait for the review of #16132 to complete.

yanavlasov · 2021-05-14T01:30:55Z

/wait

Signed-off-by: Antonio Vicente <avd@google.com>

antoniovicente · 2021-05-14T19:56:12Z

gcc failures in wasm tests look odd. Failures seem consistent though, does dbg not play nice with WASM under gcc?

https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/75652/logs/182

2021-05-14T03:57:42.2665137Z [ RUN      ] Runtimes/WasmTest.Segv/0
2021-05-14T03:57:42.2665548Z before badptr
2021-05-14T03:57:42.2665777Z 
2021-05-14T03:57:42.2665981Z 
2021-05-14T03:57:42.2666308Z #
2021-05-14T03:57:42.2667241Z # Fatal error in ../../src/runtime/runtime-wasm.cc, line 69
2021-05-14T03:57:42.2668430Z # Debug check failed: trap_handler::IsTrapHandlerEnabled() implies trap_handler::IsThreadInWasm().
2021-05-14T03:57:42.2669297Z #
2021-05-14T03:57:42.2669623Z #
2021-05-14T03:57:42.2669931Z #
2021-05-14T03:57:42.2670312Z #FailureMessage Object: 0x7ffe8106c020
2021-05-14T03:57:42.2671185Z ==== C stack trace ===============================
2021-05-14T03:57:42.2671479Z 
2021-05-14T03:57:42.2672476Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/bootstrap/wasm/wasm_test.runfiles/envoy/test/extensions/bootstrap/wasm/wasm_test(+0x14b6e23) [0x556a6e8eee23]
2021-05-14T03:57:42.2673712Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/bootstrap/wasm/wasm_test.runfiles/envoy/test/extensions/bootstrap/wasm/wasm_test(+0x991e5c) [0x556a6ddc9e5c]
2021-05-14T03:57:42.2674766Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/bootstrap/wasm/wasm_test.runfiles/envoy/test/extensions/bootstrap/wasm/wasm_test(+0x98dc19) [0x556a6ddc5c19]
2021-05-14T03:57:42.2675829Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/bootstrap/wasm/wasm_test.runfiles/envoy/test/extensions/bootstrap/wasm/wasm_test(+0x98d88c) [0x556a6ddc588c]
2021-05-14T03:57:42.2677066Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/bootstrap/wasm/wasm_test.runfiles/envoy/test/extensions/bootstrap/wasm/wasm_test(+0x98dc5d) [0x556a6ddc5c5d]
2021-05-14T03:57:42.2678139Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/bootstrap/wasm/wasm_test.runfiles/envoy/test/extensions/bootstrap/wasm/wasm_test(+0x119d1cb) [0x556a6e5d51cb]
2021-05-14T03:57:42.2679215Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/bootstrap/wasm/wasm_test.runfiles/envoy/test/extensions/bootstrap/wasm/wasm_test(+0x119e14d) [0x556a6e5d614d]
2021-05-14T03:57:42.2680297Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/bootstrap/wasm/wasm_test.runfiles/envoy/test/extensions/bootstrap/wasm/wasm_test(+0x119e109) [0x556a6e5d6109]
2021-05-14T03:57:42.2681378Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/bootstrap/wasm/wasm_test.runfiles/envoy/test/extensions/bootstrap/wasm/wasm_test(+0x179d4df) [0x556a6ebd54df]
2021-05-14T03:57:42.2682306Z ================================================================================

2021-05-14T20:26:51.6325565Z [ RUN      ] Runtimes/WasmStatSinkConfigTest.CreateWasmFromWASM/0
2021-05-14T20:26:51.6326081Z abort: thread_in_wasm flag was not set
2021-05-14T20:26:51.6326347Z 
2021-05-14T20:26:51.6326564Z 
2021-05-14T20:26:51.6326887Z #
2021-05-14T20:26:51.6329518Z # Fatal error in ../../src/wasm/wasm-code-manager.h, line 165
2021-05-14T20:26:51.6330568Z # Debug check failed: 0 <= index_ (0 vs. -1).
2021-05-14T20:26:51.6331071Z #
2021-05-14T20:26:51.6331424Z #
2021-05-14T20:26:51.6331777Z #
2021-05-14T20:26:51.6332181Z #FailureMessage Object: 0x7fffab2bc000
2021-05-14T20:26:51.6332688Z ==== C stack trace ===============================
2021-05-14T20:26:51.6332990Z 
2021-05-14T20:26:51.6333912Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x10f14cf) [0x557d63e824cf]
2021-05-14T20:26:51.6335165Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x5c5e8e) [0x557d63356e8e]
2021-05-14T20:26:51.6336410Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x5c1c4f) [0x557d63352c4f]
2021-05-14T20:26:51.6337609Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x5c18c2) [0x557d633528c2]
2021-05-14T20:26:51.6338783Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x5c1c93) [0x557d63352c93]
2021-05-14T20:26:51.6340005Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x7957fa) [0x557d635267fa]
2021-05-14T20:26:51.6341230Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x793035) [0x557d63524035]
2021-05-14T20:26:51.6342461Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x792d1c) [0x557d63523d1c]
2021-05-14T20:26:51.6343682Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x7a7c64) [0x557d63538c64]
2021-05-14T20:26:51.6344901Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x7a7d3d) [0x557d63538d3d]
2021-05-14T20:26:51.6346121Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x7a7b0d) [0x557d63538b0d]
2021-05-14T20:26:51.6347353Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x1ae6da8) [0x557d64877da8]
2021-05-14T20:26:51.6348586Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x1ae6ba2) [0x557d64877ba2]
2021-05-14T20:26:51.6349822Z     /b/f/w/bazel-out/k8-dbg/bin/test/extensions/stats_sinks/wasm/config_test.runfiles/envoy/test/extensions/stats_sinks/wasm/config_test(+0x13d7b9f) [0x557d64168b9f]

antoniovicente · 2021-05-14T19:56:18Z

/retest

repokitteh-read-only · 2021-05-14T19:56:22Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16492 (comment) was created by @antoniovicente.

see: more, trace.

PiotrSikora · 2021-05-15T02:37:56Z

gcc failures in wasm tests look odd. Failures seem consistent though, does dbg not play nice with WASM under gcc?

https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/75652/logs/182
2021-05-14T03:57:42.2665137Z [ RUN      ] Runtimes/WasmTest.Segv/0
2021-05-14T03:57:42.2665548Z before badptr
2021-05-14T03:57:42.2665777Z 
2021-05-14T03:57:42.2665981Z 
2021-05-14T03:57:42.2666308Z #
2021-05-14T03:57:42.2667241Z # Fatal error in ../../src/runtime/runtime-wasm.cc, line 69
2021-05-14T03:57:42.2668430Z # Debug check failed: trap_handler::IsTrapHandlerEnabled() implies trap_handler::IsThreadInWasm().
[...]

This is fixed in #16132.

Signed-off-by: Antonio Vicente <avd@google.com>

antoniovicente · 2021-05-20T05:44:56Z

gcc failures in wasm tests look odd. Failures seem consistent though, does dbg not play nice with WASM under gcc?
https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/75652/logs/182
2021-05-14T03:57:42.2665137Z [ RUN      ] Runtimes/WasmTest.Segv/0
2021-05-14T03:57:42.2665548Z before badptr
2021-05-14T03:57:42.2665777Z 
2021-05-14T03:57:42.2665981Z 
2021-05-14T03:57:42.2666308Z #
2021-05-14T03:57:42.2667241Z # Fatal error in ../../src/runtime/runtime-wasm.cc, line 69
2021-05-14T03:57:42.2668430Z # Debug check failed: trap_handler::IsTrapHandlerEnabled() implies trap_handler::IsThreadInWasm().
[...]
This is fixed in #16132.

Thanks for the fix and for commenting about it here. And sorry for the delayed response, been a bit distracted with other things.

antoniovicente · 2021-05-21T19:51:09Z

Blocked by #16132

/wait

PiotrSikora · 2021-05-21T20:57:18Z

Blocked by #16132

/wait

...or #16604, whichever gets merged first.

Signed-off-by: Antonio Vicente <avd@google.com>

antoniovicente · 2021-05-21T23:33:10Z

/retest

repokitteh-read-only · 2021-05-21T23:33:14Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16492 (comment) was created by @antoniovicente.

see: more, trace.

PiotrSikora · 2021-05-22T01:28:13Z

@antoniovicente you need to merge main branch.

antoniovicente · 2021-05-22T01:37:52Z

@antoniovicente you need to merge main branch.

I can try to merge again, but it seems to me that the problem is that -c dbg builds use more disk space.
Suppressed: java.io.IOException: write (No space left on device)

antoniovicente · 2021-05-22T01:41:53Z

This PR already has the latest upstream/main merged in. The issue is higher disk usage when building with -c dbg

alyssawilk · 2021-06-03T17:39:33Z

I'm going to tag this as waiting given CI failure

yanavlasov · 2021-06-09T14:11:44Z

I think we can close this one.

build: Avoid use of fastbuild when building with gcc to work around c…

66e60e5

…ommand line limit Signed-off-by: Antonio Vicente <avd@google.com>

antoniovicente assigned lizan and yanavlasov May 14, 2021

yanavlasov requested changes May 14, 2021

View reviewed changes

repokitteh-read-only bot added the waiting label May 14, 2021

also build binary in dbg

a729d09

Signed-off-by: Antonio Vicente <avd@google.com>

repokitteh-read-only bot removed the waiting label May 14, 2021

Merge remote-tracking branch 'upstream/main' into gcc_dbg

9bc5936

Signed-off-by: Antonio Vicente <avd@google.com>

antoniovicente force-pushed the gcc_dbg branch from e4c7c07 to 9bc5936 Compare May 15, 2021 03:33

Merge remote-tracking branch 'upstream/main' into gcc_dbg

fb474dd

Signed-off-by: Antonio Vicente <avd@google.com>

repokitteh-read-only bot added the waiting label May 21, 2021

lizan approved these changes May 21, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/main' into gcc_dbg

60db287

Signed-off-by: Antonio Vicente <avd@google.com>

repokitteh-read-only bot removed the waiting label May 21, 2021

alyssawilk added the waiting label Jun 3, 2021

yanavlasov removed their assignment Jun 9, 2021

yanavlasov closed this Jun 9, 2021

Conversation

antoniovicente commented May 14, 2021

Uh oh!

yanavlasov May 14, 2021

Choose a reason for hiding this comment

Uh oh!

antoniovicente May 14, 2021

Choose a reason for hiding this comment

Uh oh!

PiotrSikora May 15, 2021

Choose a reason for hiding this comment

Uh oh!

antoniovicente May 15, 2021

Choose a reason for hiding this comment

Uh oh!

yanavlasov commented May 14, 2021

Uh oh!

antoniovicente commented May 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antoniovicente commented May 14, 2021

Uh oh!

repokitteh-read-only bot commented May 14, 2021

Uh oh!

PiotrSikora commented May 15, 2021

Uh oh!

antoniovicente commented May 20, 2021

Uh oh!

antoniovicente commented May 21, 2021

Uh oh!

PiotrSikora commented May 21, 2021

Uh oh!

antoniovicente commented May 21, 2021

Uh oh!

repokitteh-read-only bot commented May 21, 2021

Uh oh!

PiotrSikora commented May 22, 2021

Uh oh!

antoniovicente commented May 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antoniovicente commented May 22, 2021

Uh oh!

alyssawilk commented Jun 3, 2021

Uh oh!

yanavlasov commented Jun 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

antoniovicente commented May 14, 2021 •

edited

Loading

antoniovicente commented May 22, 2021 •

edited

Loading