Skip to content

Workaround for CI gcc build error with long argument list #16484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanavlasov merged 2 commits into from
May 14, 2021
Merged

Workaround for CI gcc build error with long argument list #16484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb366df
Workaround CI gcc build error with long argument list
yanavlasov May 13, 2021
d7bbe41
Exclude //test/config_test:example_configs_test in gcc build
yanavlasov May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions ci/do_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,20 @@ elif [[ "$CI_TARGET" == "bazel.sizeopt" ]]; then
bazel_binary_build sizeopt
exit 0
elif [[ "$CI_TARGET" == "bazel.gcc" ]]; then
BAZEL_BUILD_OPTIONS+=("--test_env=HEAPCHECK=")
# Temporariliy exclude some extensions from the envoy binary to address build failures
# due to long command line. Tests will still run.
BAZEL_BUILD_OPTIONS+=(
"--test_env=HEAPCHECK="
"--//source/extensions/filters/network/rocketmq_proxy:enabled=False"
"--//source/extensions/filters/http/admission_control:enabled=False"
"--//source/extensions/filters/http/dynamo:enabled=False"
"--//source/extensions/filters/http/header_to_metadata:enabled=False"
"--//source/extensions/filters/http/on_demand:enabled=False")
setup_gcc_toolchain

echo "Testing ${TEST_TARGETS[*]}"
bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" -c fastbuild "${TEST_TARGETS[@]}"
# Disable //test/config_test:example_configs_test so it does not fail because of excluded extensions above
echo "Testing ${TEST_TARGETS[*]} -//test/config_test:example_configs_test"
bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" -c fastbuild -- "${TEST_TARGETS[@]}" -//test/config_test:example_configs_test
Copy link
Copy Markdown
Contributor

@antoniovicente antoniovicente May 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fastbuild is hit the hardest by command line limits because of the longer bazel output paths of "fastbuild" while "opt" and "dbg" are considerably shorter: 6 characters shorter for each of the thousands of include and library paths.

Changing the gcc CI to use opt or dbg may serve as a decent work around until we find a better alternative.


echo "bazel release build with gcc..."
bazel_binary_build fastbuild
Expand Down