Workaround for CI gcc build error with long argument list#16484
Merged
yanavlasov merged 2 commits intoenvoyproxy:mainfrom May 14, 2021
Merged
Workaround for CI gcc build error with long argument list#16484yanavlasov merged 2 commits intoenvoyproxy:mainfrom
yanavlasov merged 2 commits intoenvoyproxy:mainfrom
Conversation
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Yan Avlasov <yavlasov@google.com>
lizan
previously approved these changes
May 13, 2021
Signed-off-by: Yan Avlasov <yavlasov@google.com>
antoniovicente
approved these changes
May 14, 2021
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for the temporary workaround, it's good to unblock PRs in progress.
| bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" -c fastbuild "${TEST_TARGETS[@]}" | ||
| # Disable //test/config_test:example_configs_test so it does not fail because of excluded extensions above | ||
| echo "Testing ${TEST_TARGETS[*]} -//test/config_test:example_configs_test" | ||
| bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" -c fastbuild -- "${TEST_TARGETS[@]}" -//test/config_test:example_configs_test |
Contributor
There was a problem hiding this comment.
I think fastbuild is hit the hardest by command line limits because of the longer bazel output paths of "fastbuild" while "opt" and "dbg" are considerably shorter: 6 characters shorter for each of the thousands of include and library paths.
Changing the gcc CI to use opt or dbg may serve as a decent work around until we find a better alternative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #16196
Signed-off-by: Yan Avlasov yavlasov@google.com