test: clean up upstream protocols#16467
Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom May 18, 2021
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
@RyanTheOptimist from here it should be much easier to make the H2/H3 tests have both an H2 and an H3 upstream - just tweak that if statement to create both for the alpn advertisement case :-) |
antoniovicente
previously approved these changes
May 12, 2021
Contributor
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for the continued improvements to the test framework.
| config) { | ||
| ENVOY_LOG(info, "starting fake server on unix domain socket {}", uds_path); | ||
| } | ||
| config) {} |
Contributor
There was a problem hiding this comment.
The coverage run seems to have crashed around this line. Could you take a look?
fastbuild/bin/test/integration/uds_integration_test.runfiles/envoy/test/integration/uds_integration_test --gmock_default_mock_behavior=2 '-l trace'
2021-05-12T20:59:56.9789337Z Turning perftools heap leak checking off
2021-05-12T20:59:56.9790321Z [==========] Running 28 tests from 3 test suites.
2021-05-12T20:59:56.9791307Z [----------] Global test environment set-up.
2021-05-12T20:59:56.9792257Z [----------] 10 tests from TestParameters/UdsUpstreamIntegrationTest
2021-05-12T20:59:56.9793085Z [ RUN ] TestParameters/UdsUpstreamIntegrationTest.RouterRequestAndResponseWithBodyNoBuffer/0
2021-05-12T20:59:56.9794618Z [2021-05-12 20:59:56.357][5547][debug][runtime] [source/common/runtime/runtime_features.cc:31] Unable to use runtime singleton for feature envoy.http.headermap.lazy_map_min_size
2021-05-12T20:59:56.9796679Z [2021-05-12 20:59:56.358][5547][debug][runtime] [source/common/runtime/runtime_features.cc:20] Unable to use runtime singleton for feature envoy.reloadable_features.header_map_correctly_coalesce_cookies
2021-05-12T20:59:56.9798389Z [2021-05-12 20:59:56.362][5547][debug][runtime] [source/common/runtime/runtime_features.cc:31] Unable to use runtime singleton for feature envoy.http.headermap.lazy_map_min_size
2021-05-12T20:59:56.9800154Z [2021-05-12 20:59:56.362][5547][debug][runtime] [source/common/runtime/runtime_features.cc:20] Unable to use runtime singleton for feature envoy.reloadable_features.header_map_correctly_coalesce_cookies
2021-05-12T20:59:56.9801933Z [2021-05-12 20:59:56.363][5547][critical][backtrace] [bazel-out/k8-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:104] Caught Segmentation fault, suspect faulting address 0x0
2021-05-12T20:59:56.9802970Z #0 Envoy::SignalAction::sigHandler() [0x7fcae2c35c94]
2021-05-12T20:59:56.9803623Z #1 __restore_rt [0x7fcad1b20980]
2021-05-12T20:59:56.9804227Z #2 Envoy::FakeUpstream::FakeUpstream() [0x7fcb3f7e953e]
2021-05-12T20:59:56.9804849Z #3 [0x46eab6]
2021-05-12T20:59:56.9805354Z #4 [0x41c56e]
2021-05-12T20:59:56.9805902Z #5 Envoy::BaseIntegrationTest::initialize() [0x7fcb400ebd0e]
2021-05-12T20:59:56.9806574Z #6 Envoy::HttpIntegrationTest::initialize() [0x7fcb406260f5]
2021-05-12T20:59:56.9848246Z #7 Envoy::HttpIntegrationTest::testRouterRequestAndResponseWithBody() [0x7fcb40629d0a]
2021-05-12T20:59:56.9849230Z #8 [0x41180c]
2021-05-12T20:59:56.9849858Z #9 testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x7fcad299b146]
2021-05-12T20:59:56.9850585Z #10 testing::internal::HandleExceptionsInMethodIfSupported<>() [0x7fcad297fb01]
2021-05-12T20:59:56.9851228Z #11 testing::Test::Run() [0x7fcad2967442]
2021-05-12T20:59:56.9851778Z #12 testing::TestInfo::Run() [0x7fcad2967f58]
2021-05-12T20:59:56.9852278Z #13 testing::TestSuite::Run() [0x7fcad2968839]
2021-05-12T20:59:56.9852852Z #14 testing::internal::UnitTestImpl::RunAllTests() [0x7fcad29765e6]
2021-05-12T20:59:56.9853518Z #15 testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x7fcad29a2a56]
2021-05-12T20:59:56.9854200Z #16 testing::internal::HandleExceptionsInMethodIfSupported<>() [0x7fcad2982c51]
2021-05-12T20:59:56.9854804Z #17 testing::UnitTest::Run() [0x7fcad2976030]
2021-05-12T20:59:56.9855281Z #18 RUN_ALL_TESTS() [0x7fcaefb86885]
2021-05-12T20:59:56.9855782Z #19 Envoy::TestRunner::RunTests() [0x7fcaefb85abf]
2021-05-12T20:59:56.9856380Z #20 main [0x7fcaefb19b47]
2021-05-12T20:59:56.9857117Z #21 __libc_start_main [0x7fcad173ebf7]
2021-05-12T20:59:56.9857898Z external/bazel_tools/tools/test/collect_coverage.sh: line 131: 5547 Segmentation fault (core dumped) "$@"
ntgsx92
pushed a commit
to ntgsx92/envoy
that referenced
this pull request
May 18, 2021
Making it a bit easier to mix and match protocols and doing so more cleanly for the H3/H2 alpn tests. Risk Level: n/a (test only) Testing: tests pass Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Sixiang Gu <sgu@twitter.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Making it a bit easier to mix and match protocols and doing so more cleanly for the H3/H2 alpn tests. Risk Level: n/a (test only) Testing: tests pass Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making it a bit easier to mix and match protocols and doing so more cleanly for the H3/H2 alpn tests.
Risk Level: n/a (test only)
Testing: tests pass
Docs Changes: n/a
Release Notes: n/a