-
Notifications
You must be signed in to change notification settings - Fork 5.5k
dns: disable the use of search namespaces when using the c-ares resolver #16237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
49e3a98
5862a19
dc3d735
0804c30
690a228
285cdad
782c926
f909844
ab58afe
0035e40
50b3f52
67f2196
b3de43d
f43df93
d317f03
6580310
2716524
307d80e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -444,3 +444,19 @@ message ControlPlane { | |||||
| // the Envoy is connected to. | ||||||
| string identifier = 1; | ||||||
| } | ||||||
|
|
||||||
| // Configuration of DNS Lookup option flags which control the behavior of the DNS resolver. | ||||||
| message DnsLookupOptions { | ||||||
| // Always use TCP queries instead of UDP queries for DNS lookups. | ||||||
| // This may be overridden on a per-cluster basis in cds_config, | ||||||
| // when :ref:`dns_resolvers <envoy_api_field_config.cluster.v3.Cluster.dns_resolvers>` and | ||||||
| // :ref:`use_tcp_for_dns_lookups <envoy_api_field_config.cluster.v3.Cluster.use_tcp_for_dns_lookups>` are | ||||||
| // specified. | ||||||
| // Setting this value causes failure if the | ||||||
| // ``envoy.restart_features.use_apple_api_for_dns_lookups`` runtime value is true during | ||||||
| // server startup. Apple' API only uses UDP for DNS resolution. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Took care of this manually. thanks for noticing. |
||||||
| google.protobuf.BoolValue use_tcp_for_dns_lookups = 1; | ||||||
|
|
||||||
| // Do not use the default search domains; only query hostnames as-is or as aliases. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also I think this should be tagged with
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All the changes are committed. |
||||||
| google.protobuf.BoolValue no_defalt_search_domain = 2; | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Took care of this manually. thanks for noticing. |
||||||
| } | ||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,10 +3,12 @@ syntax = "proto3"; | |
| package envoy.extensions.common.dynamic_forward_proxy.v3; | ||
|
|
||
| import "envoy/config/cluster/v3/cluster.proto"; | ||
| import "envoy/config/core/v3/base.proto"; | ||
|
|
||
| import "google/protobuf/duration.proto"; | ||
| import "google/protobuf/wrappers.proto"; | ||
|
|
||
| import "envoy/annotations/deprecation.proto"; | ||
| import "udpa/annotations/status.proto"; | ||
| import "udpa/annotations/versioning.proto"; | ||
| import "validate/validate.proto"; | ||
|
|
@@ -27,7 +29,7 @@ message DnsCacheCircuitBreakers { | |
|
|
||
| // Configuration for the dynamic forward proxy DNS cache. See the :ref:`architecture overview | ||
| // <arch_overview_http_dynamic_forward_proxy>` for more information. | ||
| // [#next-free-field: 9] | ||
| // [#next-free-field: 10] | ||
| message DnsCacheConfig { | ||
| option (udpa.annotations.versioning).previous_message_type = | ||
| "envoy.config.common.dynamic_forward_proxy.v2alpha.DnsCacheConfig"; | ||
|
|
@@ -95,10 +97,13 @@ message DnsCacheConfig { | |
| // Envoy will use dns cache circuit breakers with default settings even if this value is not set. | ||
| DnsCacheCircuitBreakers dns_cache_circuit_breaker = 7; | ||
|
|
||
| // [#next-major-version: Reconcile DNS options in a single message.] | ||
| // Always use TCP queries instead of UDP queries for DNS lookups. | ||
| // Setting this value causes failure if the | ||
| // ``envoy.restart_features.use_apple_api_for_dns_lookups`` runtime value is true during | ||
| // server startup. Apple' API only uses UDP for DNS resolution. | ||
| bool use_tcp_for_dns_lookups = 8; | ||
| bool use_tcp_for_dns_lookups = 8 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add to the comment a reference to the configuration that should be used (instead of the deprecated one)?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added the comment. |
||
| [deprecated = true, (envoy.annotations.deprecated_at_minor_version) = "3.0"]; | ||
|
|
||
| // Configuration of DNS Lookup option flags which control the behavior of the DNS resolver. | ||
| config.core.v3.DnsLookupOptions dns_lookup_options = 9; | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I think we are heading towards a model of pluggable DNS resolvers in the not too distant future. I wonder if the DNS lookup options should reflect that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea. I never thought of that. Thank you for your suggestion. I will keep this in mind and take care of it in upcoming commits.