-
Notifications
You must be signed in to change notification settings - Fork 5.3k
dns: disable the use of search namespaces when using the c-ares resolver #16237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
49e3a98
5862a19
dc3d735
0804c30
690a228
285cdad
782c926
f909844
ab58afe
0035e40
50b3f52
67f2196
b3de43d
f43df93
d317f03
6580310
2716524
307d80e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,11 +14,28 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE; | |
|
|
||
| // [#protodoc-title: Resolver] | ||
|
|
||
| // DNS resolver configuration which includes the underlying dns resolver addresses and options. | ||
| message DnsResolver { | ||
| // A list of dns resolver addresses | ||
| // Configuration of DNS resolver option flags which control the behavior of the DNS resolver. | ||
| message DnsResolverOptions { | ||
| // Use TCP for all DNS queries instead of the default protocol UDP. | ||
| // Setting this value causes failure if the | ||
| // ``envoy.restart_features.use_apple_api_for_dns_lookups`` runtime value is true during | ||
| // server startup. Apple's API only uses UDP for DNS resolution. | ||
| bool use_tcp_for_dns_lookups = 1; | ||
|
|
||
| // Do not use the default search domains; only query hostnames as-is or as aliases. | ||
| bool no_default_search_domain = 2; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you should add a version history entry for this change.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, thanks. |
||
| } | ||
|
|
||
| // DNS resolution configuration which includes the underlying dns resolver addresses and options. | ||
| message DnsResolutionConfig { | ||
| // A list of dns resolver addresses. If specified, the DNS client library will perform resolution | ||
| // via the underlying DNS resolvers. Otherwise, the default system resolvers | ||
| // (e.g., /etc/resolv.conf) will be used. | ||
| // Setting this value causes failure if the | ||
| // ``envoy.restart_features.use_apple_api_for_dns_lookups`` runtime value is true during | ||
| // server startup. Apple's API only allows overriding DNS resolvers via system settings. | ||
| repeated Address resolvers = 1 [(validate.rules).repeated = {min_items: 1}]; | ||
|
|
||
| // Configuration of DNS resolver option flags which control the behavior of the DNS resolver. | ||
| DnsResolverOptions dns_resolver_options = 2; | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ import "envoy/config/core/v3/resolver.proto"; | |
| import "google/protobuf/duration.proto"; | ||
| import "google/protobuf/wrappers.proto"; | ||
|
|
||
| import "envoy/annotations/deprecation.proto"; | ||
| import "udpa/annotations/status.proto"; | ||
| import "udpa/annotations/versioning.proto"; | ||
| import "validate/validate.proto"; | ||
|
|
@@ -96,15 +97,15 @@ message DnsCacheConfig { | |
| // Envoy will use dns cache circuit breakers with default settings even if this value is not set. | ||
| DnsCacheCircuitBreakers dns_cache_circuit_breaker = 7; | ||
|
|
||
| // [#next-major-version: Reconcile DNS options in a single message.] | ||
| // Always use TCP queries instead of UDP queries for DNS lookups. | ||
| // Setting this value causes failure if the | ||
| // ``envoy.restart_features.use_apple_api_for_dns_lookups`` runtime value is true during | ||
| // server startup. Apple' API only uses UDP for DNS resolution. | ||
| bool use_tcp_for_dns_lookups = 8; | ||
| // This field is deprecated in favor of *dns_resolution_config* | ||
| // which aggregates all of the DNS resolver configuration in a single message. | ||
| bool use_tcp_for_dns_lookups = 8 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add to the comment a reference to the configuration that should be used (instead of the deprecated one)?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added the comment. |
||
| [deprecated = true, (envoy.annotations.deprecated_at_minor_version) = "3.0"]; | ||
|
|
||
| // DNS resolver configuration | ||
| // If specified, DNS cache will perform resolution via the underlying DNS resolvers. | ||
| // Otherwise, the default system resolvers (e.g., /etc/resolv.conf) will be used. | ||
| config.core.v3.DnsResolver dns_resolver = 9; | ||
| // DNS resolution configuration which includes the underlying dns resolver addresses and options. | ||
| config.core.v3.DnsResolutionConfig dns_resolution_config = 9; | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yanjunxiang-google this is the proto message that DNS resolver extension should live in.