grid: clean up return value#15950
Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom Apr 14, 2021
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
RyanTheOptimist
previously approved these changes
Apr 13, 2021
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Looks great! One comment about the comment :)
source/common/http/conn_pool_grid.cc
Outdated
| LinkedList::moveIntoList(std::move(wrapped_callback), wrapped_callbacks_); | ||
| // Note that in the case of immediate attempt/failure, newStream will delete this. | ||
| if (wrapped_callbacks_.front()->newStream()) { | ||
| // Note that in the case of immediate attempt/failure, newStream deletes the wrapped callback. |
Contributor
There was a problem hiding this comment.
Heh, I also re-wrote this comment (differently) in my PR, by moving the text inside the if (ImmediateResult) which is nice because the comment really only applies to that branch.
| std::vector<Http::Protocol> protocols_; | ||
| }; | ||
|
|
||
| enum class StreamCreationResult { |
Contributor
There was a problem hiding this comment.
I'm slightly surprised this doesn't exist at the general connection pool layer. But this is super great in any case!
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
douglas-reid
pushed a commit
to douglas-reid/envoy
that referenced
this pull request
Apr 19, 2021
Risk Level: n/a (code not yet used) Testing: existing tests pass Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Monkeyanator
pushed a commit
to Monkeyanator/envoy
that referenced
this pull request
Apr 20, 2021
Risk Level: n/a (code not yet used) Testing: existing tests pass Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per Greg's solid point on #15892
Risk Level: n/a (code not yet used)
Testing: existing tests pass
Docs Changes: n/a
Release Notes: n/a