grid: handle immediate success/failure#15892
Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom Apr 8, 2021
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
ggreenway
approved these changes
Apr 8, 2021
| ConnectionAttemptCallbacks(WrapperCallbacks& parent, PoolIterator it); | ||
|
|
||
| // Returns true if a stream is immediately created, false if it is pending. | ||
| bool newStream(); |
Member
There was a problem hiding this comment.
It would be more readable to have an enum instead of a bool here. But you can leave it like this if you like it better. I got confused trying to read the code before seeing this comment.
Contributor
Author
There was a problem hiding this comment.
Sounds good - will do that in a follow-up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle when newStream immediately connects/fails. In this case, all the wrappers should be immediately deleted, and return nullptr rather than returning wrappers.
Risk Level: n/a (code unused)
Testing: new unit tests
Docs Changes: n/a
Release Notes: n/a
Part of #15649