Skip to content

Fix flaky test script bug#14868

Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
rmiller14:fix_process_xml
Jan 31, 2021
Merged

Fix flaky test script bug#14868
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
rmiller14:fix_process_xml

Conversation

@rmiller14
Copy link
Contributor

Commit Message:
#14731 introduced a bug where the script tried to dump the URL of a remote that might not be present. This PR fixes that bug.

Signed-off-by: Randy Miller rmiller14@gmail.com

Risk Level: Low
Testing: Ran the script locally multiple times

Signed-off-by: Randy Miller <rmiller14@gmail.com>
@rmiller14
Copy link
Contributor Author

cc @envoyproxy/windows-dev

Copy link
Member

@davinci26 davinci26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizan for visibility

Thanks for the fix

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 6fcbe44 into envoyproxy:main Jan 31, 2021
@rmiller14 rmiller14 deleted the fix_process_xml branch February 1, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants