test: Break up router_test to avoid compiler OOM under ASAN#14844
Merged
mattklein123 merged 3 commits intoenvoyproxy:mainfrom Jan 29, 2021
Merged
test: Break up router_test to avoid compiler OOM under ASAN#14844mattklein123 merged 3 commits intoenvoyproxy:mainfrom
mattklein123 merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yan Avlasov <yavlasov@google.com>
jmarantz
reviewed
Jan 28, 2021
| srcs = [ | ||
| # Split to avoid compiler OOM, especially on ASAN. | ||
| "router_test.cc", | ||
| "router_2_test.cc", |
Contributor
There was a problem hiding this comment.
don't we need 2 test targets to run them individually?
Contributor
Author
There was a problem hiding this comment.
The problem occurs during compilation, because the file grew too large (~6K SLOC), not running the test, which is fast. I could split it into two test targets but I'm unsure how it will affect corpus generation.
Contributor
There was a problem hiding this comment.
It's config_impl_test that generates a corpus, not router_test.
Contributor
There was a problem hiding this comment.
in that case WDYT about making 2 test targets, Yan?
Contributor
|
Ah I didn't realize this was compiler-OOM. Great, thanks. The rest of this is just moving code around, right? |
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Contributor
Author
|
Correct, just copy/paste with some |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Yan Avlasov <yavlasov@google.com>
mattklein123
approved these changes
Jan 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Signed-off-by: Yan Avlasov yavlasov@google.com