cleanup: Remove unused method ServerConnectionImpl::sendProtocolErrorOld. Uses were removed by #14684#14728
Merged
asraa merged 2 commits intoenvoyproxy:mainfrom Jan 26, 2021
Merged
Conversation
…Old. Uses were removed by envoyproxy#14684 Signed-off-by: Antonio Vicente <avd@google.com>
alyssawilk
approved these changes
Jan 19, 2021
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
|
Cancelled is really bizarre, I can't figure out how to retest it. Could you try merging main and recommitting? (unless there's some other way to trigger it) |
Signed-off-by: Antonio Vicente <avd@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
cleanup: Remove unused method ServerConnectionImpl::sendProtocolErrorOld. Uses were removed by #14684
Risk Level: n/a, removing dead code
Testing: n/a, removing dead code
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a