Skip to content

hcm: removing envoy.reloadable_features.early_errors_via_hcm #14684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 1 commit into from
Jan 14, 2021
Merged

hcm: removing envoy.reloadable_features.early_errors_via_hcm #14684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/root/version_history/current.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Removed Config or Runtime
*Normally occurs at the end of the* :ref:`deprecation period <deprecated>`

* access_logs: removed legacy unbounded access logs and runtime guard `envoy.reloadable_features.disallow_unbounded_access_logs`.
* http: removed legacy HTTP/1.1 error reporting path and runtime guard `envoy.reloadable_features.early_errors_via_hcm`.

New Features
------------
Expand Down
4 changes: 0 additions & 4 deletions source/common/http/http1/codec_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,10 +1096,6 @@ void ServerConnectionImpl::sendProtocolErrorOld(absl::string_view details) {
}

Status ServerConnectionImpl::sendProtocolError(absl::string_view details) {
if (!Runtime::runtimeFeatureEnabled("envoy.reloadable_features.early_errors_via_hcm")) {
sendProtocolErrorOld(details);
Copy link
Contributor

@antoniovicente antoniovicente Jan 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sendProtocolErrorOld is no longer used. #14728

return okStatus();
}
// We do this here because we may get a protocol error before we have a logical stream.
if (!active_request_.has_value()) {
RETURN_IF_ERROR(onMessageBeginBase());
Expand Down
1 change: 0 additions & 1 deletion source/common/runtime/runtime_features.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ constexpr const char* runtime_features[] = {
"envoy.reloadable_features.consume_all_retry_headers",
"envoy.reloadable_features.check_ocsp_policy",
"envoy.reloadable_features.disable_tls_inspector_injection",
"envoy.reloadable_features.early_errors_via_hcm",
"envoy.reloadable_features.enable_dns_cache_circuit_breakers",
"envoy.reloadable_features.fix_upgrade_response",
"envoy.reloadable_features.fix_wildcard_matching",
Expand Down
18 changes: 0 additions & 18 deletions test/common/http/http1/codec_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,24 +930,6 @@ TEST_F(Http1ServerConnectionImplTest, SimpleGet) {
EXPECT_EQ(0U, buffer.length());
}

TEST_F(Http1ServerConnectionImplTest, BadRequestNoStreamLegacy) {
TestScopedRuntime scoped_runtime;
Runtime::LoaderSingleton::getExisting()->mergeValues(
{{"envoy.reloadable_features.early_errors_via_hcm", "false"}});
initialize();

std::string output;
ON_CALL(connection_, write(_, _)).WillByDefault(AddBufferToString(&output));

MockRequestDecoder decoder;
EXPECT_CALL(callbacks_, newStream(_, _)).Times(0);
EXPECT_CALL(decoder, sendLocalReply(_, _, _, _, _, _)).Times(0);

Buffer::OwnedImpl buffer("bad");
auto status = codec_->dispatch(buffer);
EXPECT_TRUE(isCodecProtocolError(status));
}

// Test that if the stream is not created at the time an error is detected, it
// is created as part of sending the protocol error.
TEST_F(Http1ServerConnectionImplTest, BadRequestNoStream) {
Expand Down