wasm: use Bazel rules from Proxy-Wasm Rust SDK.#14292
wasm: use Bazel rules from Proxy-Wasm Rust SDK.#14292lizan merged 1 commit intoenvoyproxy:masterfrom
Conversation
repokitteh-read-only
bot
added
the
deps
bazel/dependency_imports.bzl
Outdated
There was a problem hiding this comment.
I couldn't figure out what's the difference between bazel/dependency_imports.bzl and bazel/repositories_extra.bzl, so let me know if I should move proxy_wasm_rust_sdk_dependencies() elsewhere.
|
Neat. can you check CI? |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
force-pushed
the
bazel_rules_from_proxy-wasm-rust-sdk
branch
from
f4323c9 to
6b01d4c
Compare
PiotrSikora
changed the title
| project_name = "WebAssembly for Proxies (Rust SDK)", | ||
| project_desc = "WebAssembly for Proxies (Rust SDK)", | ||
| project_url = "https://github.com/proxy-wasm/proxy-wasm-rust-sdk", | ||
| version = "802cab2eabc1da106d8b8b7be2c7278b2bfadfbd", |
There was a problem hiding this comment.
This commit came just after the 0.1.3 release - https://github.com/proxy-wasm/proxy-wasm-rust-sdk/releases/tag/v0.1.3. Is the plan to leverage latest commits or use releases for this new dependency?
There was a problem hiding this comment.
Releases, but the change for better Bazel integration was added after v0.1.3 was tagged.
| strip_prefix = "rules_rust-{version}", | ||
| urls = ["https://github.com/bazelbuild/rules_rust/archive/{version}.tar.gz"], | ||
| use_category = ["dataplane_ext"], | ||
| extensions = ["envoy.wasm.runtime.wasmtime"], |
There was a problem hiding this comment.
Is this list of extensions complete? The other dependencies from this Github org have a more comprehensive list - https://github.com/envoyproxy/envoy/blob/master/bazel/repository_locations.bzl#L820-L865
There was a problem hiding this comment.
Yes, rust is only used by wasmtime runtime.
There was a problem hiding this comment.
Note: this list is referring to rules_rust and not to proxy_wasm_rust_sdk.
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
* master: (41 commits) event: Remove a source of non-determinism by always running deferred deletion before post callbacks (envoyproxy#14293) Fix TSAN bug in integration test (envoyproxy#14327) tracing: Add hostname to Zipkin config. (envoyproxy#14186) (envoyproxy#14187) [conn_pool] fix use after free in H/1 connection pool (envoyproxy#14220) lua: update deprecated lua_open to luaL_newstate (envoyproxy#14297) extension: use bool_flag to control extension link (envoyproxy#14240) stats: Factor out creation of cluster-stats StatNames from creation of the stats, to save CPU during xDS updates (envoyproxy#14028) test: add scaled timer integration test (envoyproxy#14290) [Win32 Signals] Add term and ctrl-c signal handlers (envoyproxy#13954) config: v2 transport API fatal-by-default. (envoyproxy#14223) matcher: fix UB bug caused by dereferencing a bad optional (envoyproxy#14271) test: putting fake upstream config in a struct (envoyproxy#14266) wasm: use Bazel rules from Proxy-Wasm Rust SDK. (envoyproxy#14292) docs: fix typo (envoyproxy#14237) dependencies: allowlist CVE-2018-21270 to prevent false positives. (envoyproxy#14294) typo in redis doc (envoyproxy#14248) access_loggers: removed redundant dep (envoyproxy#14274) fix http2 flaky test (envoyproxy#14261) test: disable flaky xds_integration_test. (envoyproxy#14287) http: add functionality to configure kill header in KillRequest proto (envoyproxy#14288) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
3 participants
Signed-off-by: Piotr Sikora piotrsikora@google.com