Skip to content

access_loggers: removed redundant dep#14274

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
adisuissa:remove_redundant_dep
Dec 7, 2020
Merged

access_loggers: removed redundant dep#14274
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
adisuissa:remove_redundant_dep

Conversation

@adisuissa
Copy link
Contributor

Signed-off-by: Adi Suissa-Peleg adip@google.com

Commit Message: Cleanup - removing a redundant dependency.
Additional Description:
Removing a redundant dependency from source/extensions/access_loggers/common:grpc_access_logger that was added in #14175.
Risk Level: Low
Testing: None added.
Docs Changes: None.
Release Notes: None.
Platform Specific Features: None.

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@adisuissa adisuissa requested a review from zuercher as a code owner December 4, 2020 15:01
@adisuissa
Copy link
Contributor Author

/assign @yanavlasov

@lizan
Copy link
Member

lizan commented Dec 4, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14274 (comment) was created by @lizan.

see: more, trace.

@mattklein123 mattklein123 merged commit 9f5a1d6 into envoyproxy:master Dec 7, 2020
mpuncel added a commit to mpuncel/envoy that referenced this pull request Dec 8, 2020
* master: (41 commits)
  event: Remove a source of non-determinism by always running deferred deletion before post callbacks (envoyproxy#14293)
  Fix TSAN bug in integration test (envoyproxy#14327)
  tracing: Add hostname to Zipkin config.  (envoyproxy#14186) (envoyproxy#14187)
  [conn_pool] fix use after free in H/1 connection pool (envoyproxy#14220)
  lua: update deprecated lua_open to luaL_newstate (envoyproxy#14297)
  extension: use bool_flag to control extension link (envoyproxy#14240)
  stats: Factor out creation of cluster-stats StatNames from creation of the stats, to save CPU during xDS updates (envoyproxy#14028)
  test: add scaled timer integration test (envoyproxy#14290)
  [Win32 Signals] Add term and ctrl-c signal handlers (envoyproxy#13954)
  config: v2 transport API fatal-by-default. (envoyproxy#14223)
  matcher: fix UB bug caused by dereferencing a bad optional (envoyproxy#14271)
  test: putting fake upstream config in a struct (envoyproxy#14266)
  wasm: use Bazel rules from Proxy-Wasm Rust SDK. (envoyproxy#14292)
  docs: fix typo (envoyproxy#14237)
  dependencies: allowlist CVE-2018-21270 to prevent false positives. (envoyproxy#14294)
  typo in redis doc (envoyproxy#14248)
  access_loggers: removed redundant dep (envoyproxy#14274)
  fix http2 flaky test (envoyproxy#14261)
  test: disable flaky xds_integration_test. (envoyproxy#14287)
  http: add functionality to configure kill header in KillRequest proto (envoyproxy#14288)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants