Skip to content

Fix some errors in the switch statement when decode dubbo response#14207

Merged
lizan merged 2 commits intoenvoyproxy:masterfrom
wbpcode:master
Dec 1, 2020
Merged

Fix some errors in the switch statement when decode dubbo response#14207
lizan merged 2 commits intoenvoyproxy:masterfrom
wbpcode:master

Conversation

@wbpcode
Copy link
Member

@wbpcode wbpcode commented Nov 30, 2020

Signed-off-by: wbpcode comems@msn.com

Commit Message: Fix some errors in the switch statement when decode dubbo response.
Additional Description:

It seems that there are some errors when decode the dubbo response type. But this needs to be confirmed by @zyfjeff.
If there is no problem with this code, please close this PR directly.

Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: wbpcode <comems@msn.com>
@wbpcode wbpcode requested a review from lizan as a code owner November 30, 2020 06:29
Signed-off-by: wbpcode <comems@msn.com>
@zyfjeff
Copy link
Member

zyfjeff commented Nov 30, 2020

/review @zyfjeff

Copy link
Member

@zyfjeff zyfjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@wbpcode
Copy link
Member Author

wbpcode commented Dec 1, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14207 (comment) was created by @wbpcode.

see: more, trace.

@lizan lizan merged commit 7985d81 into envoyproxy:master Dec 1, 2020
mpuncel added a commit to mpuncel/envoy that referenced this pull request Dec 2, 2020
* master: (70 commits)
  upstream: avoid reset after end_stream in TCP HTTP upstream (envoyproxy#14106)
  bazelci: add fuzz coverage (envoyproxy#14179)
  dependencies: allowlist CVE-2020-8277 to prevent false positives. (envoyproxy#14228)
  cleanup: replace ad-hoc [0, 1] value types with UnitFloat (envoyproxy#14081)
  Update docs for skywalking tracer (envoyproxy#14210)
  Fix some errors in the switch statement when decode dubbo response (envoyproxy#14207)
  Windows: enable tests and envoy-static.exe pdb file (envoyproxy#13688)
  http: add Kill Request HTTP filter (envoyproxy#14170)
  dependencies: fix release_dates error behavior. (envoyproxy#14216)
  thrift filter: support skip decoding data after metadata in the thrift message (envoyproxy#13592)
  update cares (envoyproxy#14213)
  docs: clarify behavior of hedge_on_per_try_timeout (envoyproxy#12983)
  repokitteh: add support for randomized auto-assign. (envoyproxy#14185)
  [grpc] validate grpc config for illegal characters (envoyproxy#14129)
  server: Return nullopt when process_context is nullptr (envoyproxy#14181)
  [Windows] Fix thrift proxy tests (envoyproxy#13220)
  kafka: add missing unit tests (envoyproxy#14195)
  doc: mention gperftools explicitly in PPROF.md (envoyproxy#14199)
  Removed `--use-fake-symbol-table` option. (envoyproxy#14178)
  filter contract: clarification around local replies (envoyproxy#14193)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants