repokitteh: add support for randomized auto-assign.#14185
repokitteh: add support for randomized auto-assign.#14185htuch merged 9 commits intoenvoyproxy:masterfrom
Conversation
This will allow us to pick dedicated API shepherds for each PR, ensuring we have clear review ownership. Fixes envoyproxy#13350 Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
|
This is now works and is ready for review, thanks. |
|
side q: How this is automatically assigned without blessing rk? :D |
Signed-off-by: Harvey Tuch <htuch@google.com>
|
/rk-bless |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Harvey Tuch <htuch@google.com>
|
|
||
|
|
||
| def _comment(config, results, force=False): | ||
| def _comment(config, results, assignees, sender, force=False): |
There was a problem hiding this comment.
@itayd is this the right way to get at PR author? If not can you suggest an alternative method? Would be nice to have this keyword-literal args documented to be able to figure out semantics.
There was a problem hiding this comment.
i think it is the author. to be sure though you can access the raw event using the event parameter: event.comment.user (see for example https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/814a4880-32c4-11eb-8650-62ce98aed958).
lizan
left a comment
lizan
left a comment
There was a problem hiding this comment.
LGTM, finally seeing rk assigned someone other than me :)
|
lgtm |
* master: (70 commits) upstream: avoid reset after end_stream in TCP HTTP upstream (envoyproxy#14106) bazelci: add fuzz coverage (envoyproxy#14179) dependencies: allowlist CVE-2020-8277 to prevent false positives. (envoyproxy#14228) cleanup: replace ad-hoc [0, 1] value types with UnitFloat (envoyproxy#14081) Update docs for skywalking tracer (envoyproxy#14210) Fix some errors in the switch statement when decode dubbo response (envoyproxy#14207) Windows: enable tests and envoy-static.exe pdb file (envoyproxy#13688) http: add Kill Request HTTP filter (envoyproxy#14170) dependencies: fix release_dates error behavior. (envoyproxy#14216) thrift filter: support skip decoding data after metadata in the thrift message (envoyproxy#13592) update cares (envoyproxy#14213) docs: clarify behavior of hedge_on_per_try_timeout (envoyproxy#12983) repokitteh: add support for randomized auto-assign. (envoyproxy#14185) [grpc] validate grpc config for illegal characters (envoyproxy#14129) server: Return nullopt when process_context is nullptr (envoyproxy#14181) [Windows] Fix thrift proxy tests (envoyproxy#13220) kafka: add missing unit tests (envoyproxy#14195) doc: mention gperftools explicitly in PPROF.md (envoyproxy#14199) Removed `--use-fake-symbol-table` option. (envoyproxy#14178) filter contract: clarification around local replies (envoyproxy#14193) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
4 participants
This will allow us to pick dedicated API shepherds for each PR, ensuring
we have clear review ownership.
Fixes #13350
Signed-off-by: Harvey Tuch htuch@google.com