test: use simulated time for Envoy server in integration test#14144
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Nov 23, 2020
Merged
test: use simulated time for Envoy server in integration test#14144mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Use simulated time for the integration test to ensure that timers don't time out due to the test running slow. This prevents test flakes, and TSAN errors when running in that mode. Signed-off-by: Alex Konradi <akonradi@google.com>
qqustc
pushed a commit
to qqustc/envoy
that referenced
this pull request
Nov 24, 2020
Use simulated time for the integration test to ensure that timers don't time out due to the test running slow. This prevents test flakes, and TSAN errors when running in that mode. Signed-off-by: Alex Konradi <akonradi@google.com> Signed-off-by: Qin Qin <qqin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Use simulated time for integration test Envoy
Additional Description:
Use simulated time for the integration test to ensure that timers don't
time out due to the test running slow. This prevents test flakes, and
TSAN errors when running in that mode.
Risk Level: low
Testing: ran affected test 100+ times
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a