Skip to content

backport to 1.16: examples: Fix deprecations/warnings in configs (#13503)#14110

Closed
antoniovicente wants to merge 1 commit intoenvoyproxy:release/v1.16from
antoniovicente:more_example_warnings_v1.16
Closed

backport to 1.16: examples: Fix deprecations/warnings in configs (#13503)#14110
antoniovicente wants to merge 1 commit intoenvoyproxy:release/v1.16from
antoniovicente:more_example_warnings_v1.16

Conversation

@antoniovicente
Copy link
Contributor

No description provided.

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Antonio Vicente <avd@google.com>
@phlax
Copy link
Member

phlax commented Nov 20, 2020

hi @antoniovicente not sure how thorough you want to be but it seems like this doesnt catch all of the warnings

eg - see here https://dev.azure.com/cncf/envoy/_build/results?buildId=58106&view=logs&j=f1a49366-51c0-540f-0294-f73c2bb311a9&t=7fd036c9-61ec-5b59-3645-e90950dc67a6&l=956

@phlax
Copy link
Member

phlax commented Nov 20, 2020

checking the commit log there were 2 prs/commits to address this 1dd8c12 and 328ffbe

im think you only grabbed one of them

@antoniovicente
Copy link
Contributor Author

Addressed by #14125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants