tls: allow nullptr as slot value - #13883
Merged
Merged
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
reviewed
Nov 3, 2020
mattklein123
left a comment
mattklein123
left a comment
Member
There was a problem hiding this comment.
Very nice! I like it. LMK when you are ready for review.
FWIW, if you want some additional easy coding therapy, there are a ton of other callsites that would benefit from that wrapper. 👍
/wait
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
marked this pull request as ready for review
November 3, 2020 23:16
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
I think this is ready for review now; tests & doc are added. |
mattklein123
approved these changes
Nov 4, 2020
mattklein123
left a comment
mattklein123
left a comment
Member
There was a problem hiding this comment.
Thanks regardless of what happens on the other PR this is a nice improvement as we get rid of more runOnAllThreads() variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: add support for null data to tls slot typed API, using optional references. To make these less cumbersome at call-sites, add a struct OptRef wrapper for absl::optional<std::reference_wrapper> that allows directly accessing via
->syntax if the caller can guarantee the optional reference is populated.Additional Description:
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a