wasm: allow execution of multiple instances of the same plugin. by PiotrSikora · Pull Request #13753 · envoyproxy/envoy

PiotrSikora · 2020-10-26T07:58:54Z

Signed-off-by: Piotr Sikora piotrsikora@google.com

repokitteh-read-only · 2020-10-26T07:59:00Z

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #13753 was opened by PiotrSikora.

see: more, trace.

lizan · 2020-10-27T20:00:34Z

@mathetake

mathetake · 2020-10-27T23:55:05Z

@lizan I got the context by following related issues.

@PiotrSikora If there's anything I can help, let me know

Fixes envoyproxy#13690. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

PiotrSikora · 2020-10-29T05:47:51Z

@mathetake this is ready for review now (@lizan could we add @mathetake to assignable?)

source/extensions/common/wasm/context.cc

bazel/repository_locations.bzl

test/extensions/common/wasm/wasm_test.cc

source/extensions/common/wasm/context.cc

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

source/extensions/filters/network/wasm/wasm_filter.h

mathetake

I've tested this against proxy-wasm-go-sdk's e2e and it works as well! LGTM after the fix of proxy-wasm-cpp-host repository location @PiotrSikora

Signed-off-by: mathetake <takeshi@tetrate.io>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

…nfig_id Signed-off-by: Piotr Sikora <piotrsikora@google.com>

source/extensions/bootstrap/wasm/config.h

source/extensions/filters/http/wasm/wasm_filter.h

mathetake

I realize that usign tls_slog->get() would cause a crash during shutdown (e.g. handling SIGTERM) if it's not a release build: https://github.com/envoyproxy/envoy/blob/master/source/common/thread_local/thread_local_impl.cc#L66-L66

looks like using currentThreadRegistered would be better to check if the slot exists

source/extensions/filters/network/wasm/wasm_filter.cc

source/extensions/filters/http/wasm/wasm_filter.cc

source/extensions/bootstrap/wasm/config.h

source/extensions/access_loggers/wasm/wasm_access_log_impl.h

…nfig_id

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

mattklein123 · 2020-11-10T01:12:33Z

Thanks for iterating, this looks much better. LMK when this is ready for review again and not pointing at your branch.

/wait

…nfig_id

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

PiotrSikora · 2020-11-10T10:05:31Z

@mattklein123 this should be good to go, but it needs #13930 and #13932 to be merged first.

mattklein123 · 2020-11-10T16:45:50Z

OK just ping me when this is ready.

/wait

…nfig_id Signed-off-by: Piotr Sikora <piotrsikora@google.com>

PiotrSikora · 2020-11-12T07:09:16Z

@mattklein123 all other PRs are now merged, so this is ready for review / merge. Thanks!

cc @envoyproxy/dependency-shepherds for dependency update.

mattklein123

Nice cleanup, thanks.

repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 26, 2020

PiotrSikora mentioned this pull request Oct 26, 2020

wasm: plugin configuration is racey #13690

Closed

mathetake mentioned this pull request Oct 27, 2020

Allow execution of multiple instances of the same plugin. proxy-wasm/proxy-wasm-cpp-host#78

Merged

mattklein123 self-assigned this Oct 28, 2020

mattklein123 added the waiting label Oct 28, 2020

wasm: allow execution of multiple instances of the same plugin.

697dc19

Fixes envoyproxy#13690. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

PiotrSikora force-pushed the wasm_config_id branch from 1987a19 to 697dc19 Compare October 29, 2020 05:40

repokitteh-read-only bot removed the waiting label Oct 29, 2020

PiotrSikora requested review from kyessenov and lizan October 29, 2020 05:44

PiotrSikora marked this pull request as ready for review October 29, 2020 05:46

PiotrSikora mentioned this pull request Oct 29, 2020

wasm: TCP stats share state with HTTP stats, and configurations race istio/istio#28017

Closed

mathetake reviewed Oct 29, 2020

View reviewed changes

source/extensions/common/wasm/context.cc Show resolved Hide resolved

PiotrSikora commented Oct 29, 2020

View reviewed changes

bazel/repository_locations.bzl Outdated Show resolved Hide resolved

test/extensions/common/wasm/wasm_test.cc Outdated Show resolved Hide resolved

source/extensions/common/wasm/context.cc Show resolved Hide resolved

review: fix clang-tidy.

672c1ff

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

mathetake reviewed Oct 29, 2020

View reviewed changes

source/extensions/filters/network/wasm/wasm_filter.h Show resolved Hide resolved

mathetake reviewed Oct 29, 2020

View reviewed changes

mathetake and others added 3 commits October 30, 2020 08:34

wasm: remove the gap between rust and cpp test code for logging

8d49c1d

Signed-off-by: mathetake <takeshi@tetrate.io>

review: use merged commit.

9f98a40

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Merge remote-tracking branch 'origin/master' into PiotrSikora/wasm_co…

60003c1

…nfig_id Signed-off-by: Piotr Sikora <piotrsikora@google.com>

PiotrSikora requested review from htuch, mattklein123 and moderation October 30, 2020 10:33

lizan reviewed Nov 2, 2020

View reviewed changes

source/extensions/bootstrap/wasm/config.h Outdated Show resolved Hide resolved

source/extensions/filters/http/wasm/wasm_filter.h Outdated Show resolved Hide resolved

mathetake requested changes Nov 2, 2020

View reviewed changes

Merge remote-tracking branch 'origin/master' into PiotrSikora/wasm_co…

6f3392a

…nfig_id

review: use PluginHandle for shutdown-on-destroy semantics.

9965dcd

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

repokitteh-read-only bot added deps Approval required for changes to Envoy's external dependencies and removed waiting labels Nov 10, 2020

repokitteh-read-only bot added the waiting label Nov 10, 2020

PiotrSikora added 2 commits November 10, 2020 08:59

Merge remote-tracking branch 'origin/master' into PiotrSikora/wasm_co…

f16ba7d

…nfig_id

review: point at merged commit.

3d4e28e

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

repokitteh-read-only bot removed the waiting label Nov 10, 2020

review: update release date.

d128aaf

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

repokitteh-read-only bot added the waiting label Nov 10, 2020

Merge remote-tracking branch 'origin/master' into PiotrSikora/wasm_co…

7bc7c9a

…nfig_id Signed-off-by: Piotr Sikora <piotrsikora@google.com>

repokitteh-read-only bot removed the waiting label Nov 11, 2020

mattklein123 added the waiting label Nov 12, 2020

PiotrSikora mentioned this pull request Nov 12, 2020

wasm: Add Wasmtime as a new runtime #13932

Merged

Merge remote-tracking branch 'origin/master' into PiotrSikora/wasm_co…

e15e498

…nfig_id Signed-off-by: Piotr Sikora <piotrsikora@google.com>

repokitteh-read-only bot removed the waiting label Nov 12, 2020

PiotrSikora requested review from mathetake and mattklein123 November 12, 2020 07:09

mathetake approved these changes Nov 12, 2020

View reviewed changes

PiotrSikora mentioned this pull request Nov 12, 2020

wasm: fix order of callbacks for paused requests. #13840

Merged

mattklein123 approved these changes Nov 12, 2020

View reviewed changes

mattklein123 merged commit 3c8e56a into envoyproxy:master Nov 12, 2020

Conversation

PiotrSikora commented Oct 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Oct 26, 2020

Uh oh!

lizan commented Oct 27, 2020

Uh oh!

mathetake commented Oct 27, 2020

Uh oh!

PiotrSikora commented Oct 29, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mathetake left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mathetake left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattklein123 commented Nov 10, 2020

Uh oh!

PiotrSikora commented Nov 10, 2020

Uh oh!

mattklein123 commented Nov 10, 2020

Uh oh!

PiotrSikora commented Nov 12, 2020

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

PiotrSikora commented Oct 26, 2020 •

edited

Loading

mathetake left a comment •

edited

Loading