-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Migrate resource monitors (fixed heap & injected resource ) , redis and thrift_proxy filter to api v3 #13814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ankatare
wants to merge
38
commits into
envoyproxy:main
from
ankatare:Migrate_FixedHeap_resource_monitor_toapi_v3
Closed
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
8a577f9
v2 packages to v3
ankatare 6f8f289
Fixing bug 12841
ankatare 57df902
fixing format issues in build
ankatare 2a5b3e0
fixing proto issue in build
ankatare 7b21edc
local changes for proto format fix
ankatare 33bcc2c
proto format locally
ankatare a714e4b
proto format fix for redis
ankatare c0337cc
local changes
ankatare 9c494ff
local proto path changes
ankatare 6bcc762
local changes for proto format
ankatare 7da0583
local proto tree changes
ankatare ee69ed8
local changes for new protos
ankatare 4172bf5
local changes for new proto
ankatare db4700d
format changes
ankatare 5405204
local changes for new proto
ankatare c0469c3
proto changes
ankatare 86ebbb3
proto changes
ankatare 8c0ecc4
changes for new protos docs changes
ankatare facb65a
fixing build issues due to overload.proto etc
ankatare 270bfb2
fixing BUILD files issues in ci build
ankatare ec1a23a
changes wrt v2 protos
ankatare 633864d
fix proto issues and fix for PR 13885
ankatare 470259d
v2 protos frozen for redis
ankatare 029b221
v2 proto changes for redis
ankatare 4997e40
v2 proto changes to FROZEN for fixed_heap
ankatare a480bef
v2 proto changes to FROZEN
ankatare 8b678a2
v2 protos marked as FROZEN for redis,fixed_heap and injected resources
ankatare a9e100c
fixing build issues, incorporated review comments of harvey to exclud…
ankatare 044180c
incorporate review comments by harvey to put exclude_v2_protos variab…
ankatare 29b7556
Merge branch 'master' into Migrate_FixedHeap_resource_monitor_toapi_v3
ankatare 941e36c
Merge remote-tracking branch 'upstream/master' into Migrate_FixedHeap…
ankatare 023eec5
Merge branch 'Migrate_FixedHeap_resource_monitor_toapi_v3' of https:/…
ankatare af59960
incorporated review commnets of putting logic inside api_type_oracle.cc
ankatare 8cec235
incorporated review commnets of putting logic inside api_type_oracle.cc
ankatare 9d055be
incorporated review comments and wrote unit test for api_type_oracle,…
ankatare 7ab40e5
incorporated review comments and wrote unit test for api_type_oracle,…
ankatare 89cac3c
Merge branch 'Migrate_FixedHeap_resource_monitor_toapi_v3' of https:/…
ankatare b448eb1
putting debug log to trace the issue
ankatare File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # DO NOT EDIT. This file is generated by tools/proto_format/proto_sync.py. | ||
|
|
||
| load("@envoy_api//bazel:api_build_system.bzl", "api_proto_package") | ||
|
|
||
| licenses(["notice"]) # Apache 2 | ||
|
|
||
| api_proto_package( | ||
| deps = [ | ||
| "//envoy/config/health_checker/redis/v2:pkg", | ||
| "@com_github_cncf_udpa//udpa/annotations:pkg", | ||
| ], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package envoy.config.health_checker.redis.v3; | ||
|
|
||
| import "udpa/annotations/status.proto"; | ||
| import "udpa/annotations/versioning.proto"; | ||
|
|
||
| option java_package = "io.envoyproxy.envoy.config.health_checker.redis.v3"; | ||
| option java_outer_classname = "RedisProto"; | ||
| option java_multiple_files = true; | ||
| option (udpa.annotations.file_status).package_version_status = ACTIVE; | ||
|
|
||
| // [#protodoc-title: Redis] | ||
| // Redis health checker :ref:`configuration overview <config_health_checkers_redis>`. | ||
| // [#extension: envoy.health_checkers.redis] | ||
|
|
||
| message Redis { | ||
| option (udpa.annotations.versioning).previous_message_type = | ||
| "envoy.config.health_checker.redis.v2.Redis"; | ||
|
|
||
| // If set, optionally perform ``EXISTS <key>`` instead of ``PING``. A return value | ||
| // from Redis of 0 (does not exist) is considered a passing healthcheck. A return value other | ||
| // than 0 is considered a failure. This allows the user to mark a Redis instance for maintenance | ||
| // by setting the specified key to any value and waiting for traffic to drain. | ||
| string key = 1; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # DO NOT EDIT. This file is generated by tools/proto_format/proto_sync.py. | ||
|
|
||
| load("@envoy_api//bazel:api_build_system.bzl", "api_proto_package") | ||
|
|
||
| licenses(["notice"]) # Apache 2 | ||
|
|
||
| api_proto_package( | ||
| deps = [ | ||
| "//envoy/config/resource_monitor/fixed_heap/v2alpha:pkg", | ||
| "@com_github_cncf_udpa//udpa/annotations:pkg", | ||
| ], | ||
| ) |
25 changes: 25 additions & 0 deletions
25
api/envoy/config/resource_monitor/fixed_heap/v3/fixed_heap.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package envoy.config.resource_monitor.fixed_heap.v3; | ||
|
|
||
| import "udpa/annotations/status.proto"; | ||
| import "udpa/annotations/versioning.proto"; | ||
| import "validate/validate.proto"; | ||
|
|
||
| option java_package = "io.envoyproxy.envoy.config.resource_monitor.fixed_heap.v3"; | ||
| option java_outer_classname = "FixedHeapProto"; | ||
| option java_multiple_files = true; | ||
| option (udpa.annotations.file_status).package_version_status = ACTIVE; | ||
|
|
||
| // [#protodoc-title: Fixed heap] | ||
| // [#extension: envoy.resource_monitors.fixed_heap] | ||
|
|
||
| // The fixed heap resource monitor reports the Envoy process memory pressure, computed as a | ||
| // fraction of currently reserved heap memory divided by a statically configured maximum | ||
| // specified in the FixedHeapConfig. | ||
| message FixedHeapConfig { | ||
| option (udpa.annotations.versioning).previous_message_type = | ||
| "envoy.config.resource_monitor.fixed_heap.v2alpha.FixedHeapConfig"; | ||
|
|
||
| uint64 max_heap_size_bytes = 1 [(validate.rules).uint64 = {gt: 0}]; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
api/envoy/config/resource_monitor/injected_resource/v3/BUILD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # DO NOT EDIT. This file is generated by tools/proto_format/proto_sync.py. | ||
|
|
||
| load("@envoy_api//bazel:api_build_system.bzl", "api_proto_package") | ||
|
|
||
| licenses(["notice"]) # Apache 2 | ||
|
|
||
| api_proto_package( | ||
| deps = [ | ||
| "//envoy/config/resource_monitor/injected_resource/v2alpha:pkg", | ||
| "@com_github_cncf_udpa//udpa/annotations:pkg", | ||
| ], | ||
| ) |
26 changes: 26 additions & 0 deletions
26
api/envoy/config/resource_monitor/injected_resource/v3/injected_resource.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package envoy.config.resource_monitor.injected_resource.v3; | ||
|
|
||
| import "udpa/annotations/status.proto"; | ||
| import "udpa/annotations/versioning.proto"; | ||
| import "validate/validate.proto"; | ||
|
|
||
| option java_package = "io.envoyproxy.envoy.config.resource_monitor.injected_resource.v3"; | ||
| option java_outer_classname = "InjectedResourceProto"; | ||
| option java_multiple_files = true; | ||
| option (udpa.annotations.file_status).package_version_status = ACTIVE; | ||
|
|
||
| // [#protodoc-title: Injected resource] | ||
| // [#extension: envoy.resource_monitors.injected_resource] | ||
|
|
||
| // The injected resource monitor allows injecting a synthetic resource pressure into Envoy | ||
| // via a text file, which must contain a floating-point number in the range [0..1] representing | ||
| // the resource pressure and be updated atomically by a symbolic link swap. | ||
| // This is intended primarily for integration tests to force Envoy into an overloaded state. | ||
| message InjectedResourceConfig { | ||
| option (udpa.annotations.versioning).previous_message_type = | ||
| "envoy.config.resource_monitor.injected_resource.v2alpha.InjectedResourceConfig"; | ||
|
|
||
| string filename = 1 [(validate.rules).string = {min_len: 1}]; | ||
| } |
12 changes: 12 additions & 0 deletions
12
api/envoy/extensions/filters/network/thrift_proxy/router/v3/BUILD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # DO NOT EDIT. This file is generated by tools/proto_format/proto_sync.py. | ||
|
|
||
| load("@envoy_api//bazel:api_build_system.bzl", "api_proto_package") | ||
|
|
||
| licenses(["notice"]) # Apache 2 | ||
|
|
||
| api_proto_package( | ||
| deps = [ | ||
| "//envoy/config/filter/thrift/router/v2alpha1:pkg", | ||
| "@com_github_cncf_udpa//udpa/annotations:pkg", | ||
| ], | ||
| ) |
20 changes: 20 additions & 0 deletions
20
api/envoy/extensions/filters/network/thrift_proxy/router/v3/router.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package envoy.extensions.filters.network.thrift_proxy.router.v3; | ||
|
|
||
| import "udpa/annotations/status.proto"; | ||
| import "udpa/annotations/versioning.proto"; | ||
|
|
||
| option java_package = "io.envoyproxy.envoy.extensions.filters.network.thrift_proxy.router.v3"; | ||
| option java_outer_classname = "RouterProto"; | ||
| option java_multiple_files = true; | ||
| option (udpa.annotations.file_status).package_version_status = ACTIVE; | ||
|
|
||
| // [#protodoc-title: Router] | ||
| // Thrift router :ref:`configuration overview <config_thrift_filters_router>`. | ||
| // [#extension: envoy.filters.thrift.router] | ||
|
|
||
| message Router { | ||
| option (udpa.annotations.versioning).previous_message_type = | ||
| "envoy.config.filter.thrift.router.v2alpha1.Router"; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # DO NOT EDIT. This file is generated by tools/proto_format/proto_sync.py. | ||
|
|
||
| load("@envoy_api//bazel:api_build_system.bzl", "api_proto_package") | ||
|
|
||
| licenses(["notice"]) # Apache 2 | ||
|
|
||
| api_proto_package( | ||
| deps = ["@com_github_cncf_udpa//udpa/annotations:pkg"], | ||
| ) |
16 changes: 16 additions & 0 deletions
16
api/envoy/extensions/retry/host/omit_canary_hosts/v3/omit_canary_hosts.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package envoy.extensions.retry.host.omit_canary_hosts.v3; | ||
|
|
||
| import "udpa/annotations/status.proto"; | ||
|
|
||
| option java_package = "io.envoyproxy.envoy.extensions.retry.host.omit_canary_hosts.v3"; | ||
| option java_outer_classname = "OmitCanaryHostsProto"; | ||
| option java_multiple_files = true; | ||
| option (udpa.annotations.file_status).package_version_status = ACTIVE; | ||
|
|
||
| // [#protodoc-title: Omit Canary Hosts Predicate] | ||
| // [#extension: envoy.retry_host_predicates.omit_canary_hosts] | ||
|
|
||
| message OmitCanaryHostsPredicate { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # DO NOT EDIT. This file is generated by tools/proto_format/proto_sync.py. | ||
|
|
||
| load("@envoy_api//bazel:api_build_system.bzl", "api_proto_package") | ||
|
|
||
| licenses(["notice"]) # Apache 2 | ||
|
|
||
| api_proto_package( | ||
| deps = ["@com_github_cncf_udpa//udpa/annotations:pkg"], | ||
| ) |
16 changes: 16 additions & 0 deletions
16
api/envoy/extensions/retry/host/previous_hosts/v3/previous_hosts.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package envoy.extensions.retry.host.previous_hosts.v3; | ||
|
|
||
| import "udpa/annotations/status.proto"; | ||
|
|
||
| option java_package = "io.envoyproxy.envoy.extensions.retry.host.previous_hosts.v3"; | ||
| option java_outer_classname = "PreviousHostsProto"; | ||
| option java_multiple_files = true; | ||
| option (udpa.annotations.file_status).package_version_status = ACTIVE; | ||
|
|
||
| // [#protodoc-title: Previous Hosts Predicate] | ||
| // [#extension: envoy.retry_host_predicates.previous_hosts] | ||
|
|
||
| message PreviousHostsPredicate { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,5 @@ Health checkers | |
| :glob: | ||
| :maxdepth: 2 | ||
|
|
||
| */v2/* | ||
| */v2/* | ||
| */v3/* | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,4 +7,5 @@ Resource monitors | |
| :glob: | ||
| :maxdepth: 2 | ||
|
|
||
| */v3/* | ||
| */v2alpha/* | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.