Migrate resource monitors (fixed heap & injected resource ) , redis and thrift_proxy filter to api v3 by ankatare · Pull Request #13814 · envoyproxy/envoy

ankatare · 2020-10-29T07:38:15Z

Commit Message: Migrate resource monitors (fixed heap & injected resource ) , redis and thrift_proxy filter to api v3
Additional Description: Copying remaining v2 packages under proto_library ove to v3 trees. which also fulfil requirements of #12841.
Risk Level: LOW
Testing: proto_format test
Docs Changes: Yes
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Optional Fixes #12841
[Optional Deprecated:]

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

repokitteh-read-only · 2020-10-29T07:38:21Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #13814 was opened by ankatare.

see: more, trace.

yanavlasov · 2020-10-29T14:53:42Z

I think you have migrated quite a bit more than just fixed heap resource monitor. Can you update the title and description to match the scope of your change, please?
You will need to fix format errors in the new files. Please run tools/code_format/check_format.py check to see the errors.

yanavlasov · 2020-10-29T14:54:18Z

/wait

ankatare · 2020-10-29T15:43:45Z

@yanavlasov thanks for comments. i updated Additional Description part. please let me know if it is ok now !!

ankatare · 2020-10-29T15:44:25Z

@yanavlasov moreover yes, i will run script as you suggested to fix build issues.

ankatare · 2020-10-29T18:22:13Z

sorry !!! seems , some local env issues on build . looking into it !!!

yanavlasov · 2020-11-03T17:26:55Z

Would you be able to update documentation to reference newly versioned proto files as well please? For instance thrift router doc still refers to the v2alpha1 proto. See here:

yanavlasov · 2020-11-03T17:27:21Z

/wait

ankatare · 2020-11-03T17:36:52Z

@yanavlasov OK.

ankatare · 2020-11-03T17:37:35Z

currently looking at build issues https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/56106/logs/24

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

htuch · 2020-11-09T20:42:43Z

@ankatare please ping me back when you have format and docs passing. Thanks.

ankatare · 2020-11-10T04:26:03Z

@htuch sure.

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

ankatare · 2020-11-10T14:09:40Z

seems docs issue again :( checking it locally

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

ankatare · 2020-11-11T19:33:20Z

still working on fixing issues in my local env. will try to close it ASAP

source/common/protobuf/utility.cc

…_resource_monitor_toapi_v3

…/github.com/ankatare/envoy into Migrate_FixedHeap_resource_monitor_toapi_v3

htuch

Looks good, but still needs unit tests.

source/common/protobuf/utility.cc

source/common/config/api_type_oracle.cc

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

ankatare · 2021-01-08T00:36:16Z

/retest

repokitteh-read-only · 2021-01-08T00:36:19Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13814 (comment) was created by @ankatare.

see: more, trace.

ankatare · 2021-01-08T00:55:27Z

really sorry for this build failure. rechecking in my local env

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

htuch

Looks good, just needs some tests.
/wait

source/common/config/api_type_oracle.cc

ankatare · 2021-01-11T09:14:11Z

@htuch unit test for api_type_oracle.cc is done. please review

… also tracking it with issue as envoyproxy#14197 Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

htuch

LGTM, thanks!

… also tracking it with issue as envoyproxy#14197 Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

…/github.com/ankatare/envoy into Migrate_FixedHeap_resource_monitor_toapi_v3

ankatare · 2021-01-15T02:51:07Z

pushed code again (with latest merge master) for fixing errors in windows

ankatare · 2021-01-17T02:33:09Z

cc @envoyproxy/windows-dev for windows issue.

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

ankatare · 2021-01-17T16:20:28Z

@htuch Hi, i don't know what is meaning of "ankatare dismissed htuch’s stale review via b448eb1 ". i just pushed some debug log as suggested by community. ( @davinci26 )

source/common/config/api_type_oracle.cc

htuch · 2021-01-20T14:18:05Z

I've reassigned the issue my way, will close out this PR. Thanks for the help and I'll use this as the basis.

ankatare added 2 commits October 27, 2020 01:31

v2 packages to v3

8a577f9

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

Fixing bug 12841

6f8f289

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

repokitteh-read-only bot added the api label Oct 29, 2020

repokitteh-read-only bot added the waiting label Oct 29, 2020

repokitteh-read-only bot removed the waiting label Oct 29, 2020

ankatare force-pushed the Migrate_FixedHeap_resource_monitor_toapi_v3 branch from 6ffa202 to 7dfa9ad Compare October 31, 2020 01:09

mattklein123 assigned yanavlasov Oct 31, 2020

repokitteh-read-only bot added the waiting label Nov 3, 2020

fixing format issues in build

57df902

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

ankatare force-pushed the Migrate_FixedHeap_resource_monitor_toapi_v3 branch from 7dfa9ad to 57df902 Compare November 3, 2020 19:02

repokitteh-read-only bot removed the waiting label Nov 3, 2020

fixing proto issue in build

2a5b3e0

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

ankatare added 4 commits November 11, 2020 23:53

local changes for proto format fix

7b21edc

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

proto format locally

33bcc2c

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

proto format fix for redis

a714e4b

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

local changes

c0337cc

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

dio reviewed Dec 22, 2020

View reviewed changes

source/common/protobuf/utility.cc Outdated Show resolved Hide resolved

ankatare added 2 commits December 22, 2020 19:07

Merge remote-tracking branch 'upstream/master' into Migrate_FixedHeap…

941e36c

…_resource_monitor_toapi_v3

Merge branch 'Migrate_FixedHeap_resource_monitor_toapi_v3' of https:/…

023eec5

…/github.com/ankatare/envoy into Migrate_FixedHeap_resource_monitor_toapi_v3

htuch reviewed Jan 6, 2021

View reviewed changes

source/common/protobuf/utility.cc Outdated Show resolved Hide resolved

source/common/config/api_type_oracle.cc Outdated Show resolved Hide resolved

incorporated review commnets of putting logic inside api_type_oracle.cc

af59960

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

incorporated review commnets of putting logic inside api_type_oracle.cc

8cec235

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

ankatare force-pushed the Migrate_FixedHeap_resource_monitor_toapi_v3 branch from af59960 to 8cec235 Compare January 8, 2021 10:41

htuch suggested changes Jan 11, 2021

View reviewed changes

source/common/config/api_type_oracle.cc Outdated Show resolved Hide resolved

source/common/config/api_type_oracle.cc Outdated Show resolved Hide resolved

repokitteh-read-only bot added waiting and removed waiting labels Jan 11, 2021

incorporated review comments and wrote unit test for api_type_oracle,…

9d055be

… also tracking it with issue as envoyproxy#14197 Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

ankatare force-pushed the Migrate_FixedHeap_resource_monitor_toapi_v3 branch from 32c7bb3 to 9d055be Compare January 11, 2021 10:37

htuch previously approved these changes Jan 13, 2021

View reviewed changes

ankatare added 2 commits January 15, 2021 08:18

incorporated review comments and wrote unit test for api_type_oracle,…

7ab40e5

… also tracking it with issue as envoyproxy#14197 Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

Merge branch 'Migrate_FixedHeap_resource_monitor_toapi_v3' of https:/…

89cac3c

…/github.com/ankatare/envoy into Migrate_FixedHeap_resource_monitor_toapi_v3

Base automatically changed from master to main January 15, 2021 23:01

ankatare mentioned this pull request Jan 17, 2021

Build issue in windows env [error: SEH exception with code 0xc0000005 thrown in the test body ] #14725

Closed

putting debug log to trace the issue

b448eb1

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>

ankatare dismissed htuch’s stale review via b448eb1 January 17, 2021 16:15

htuch reviewed Jan 18, 2021

View reviewed changes

source/common/config/api_type_oracle.cc Show resolved Hide resolved

htuch closed this Jan 20, 2021

ankatare deleted the Migrate_FixedHeap_resource_monitor_toapi_v3 branch February 12, 2021 05:39

Conversation

ankatare commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Oct 29, 2020

Uh oh!

yanavlasov commented Oct 29, 2020

Uh oh!

yanavlasov commented Oct 29, 2020

Uh oh!

ankatare commented Oct 29, 2020

Uh oh!

ankatare commented Oct 29, 2020

Uh oh!

ankatare commented Oct 29, 2020

Uh oh!

yanavlasov commented Nov 3, 2020

Uh oh!

yanavlasov commented Nov 3, 2020

Uh oh!

ankatare commented Nov 3, 2020

Uh oh!

ankatare commented Nov 3, 2020

Uh oh!

htuch commented Nov 9, 2020

Uh oh!

ankatare commented Nov 10, 2020

Uh oh!

ankatare commented Nov 10, 2020

Uh oh!

ankatare commented Nov 11, 2020

Uh oh!

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ankatare commented Jan 8, 2021

Uh oh!

repokitteh-read-only bot commented Jan 8, 2021

Uh oh!

ankatare commented Jan 8, 2021

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ankatare commented Jan 11, 2021

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

ankatare commented Jan 15, 2021

Uh oh!

ankatare commented Jan 17, 2021

Uh oh!

ankatare commented Jan 17, 2021

Uh oh!

Uh oh!

htuch commented Jan 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ankatare commented Oct 29, 2020 •

edited

Loading